Skip to content

Fix leaking handler in date format setup#806

Merged
rxaviers merged 1 commit into
globalizejs:masterfrom
SlexAxton:alex-date-perf
Mar 9, 2018
Merged

Fix leaking handler in date format setup#806
rxaviers merged 1 commit into
globalizejs:masterfrom
SlexAxton:alex-date-perf

Conversation

@SlexAxton
Copy link
Copy Markdown
Contributor

@SlexAxton SlexAxton commented Mar 9, 2018

A coworker of mine patched this locally because we were experiencing progressive slow-downs the more we rendered certain pages with lots of dates.

They are adding and removing an event listener from cldr when we pass in options.timeZone, but since they are constructing the listener with a generator function, they aren't actually removing the one they added. I'll see if I can modify this function and check if that fixes it.

<3z,
Alex
@jsf-clabot
Copy link
Copy Markdown

jsf-clabot commented Mar 9, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.
@SlexAxton
Date: Fix leaking handler
3801452 
In certain situations we weren't always cleaning up an event handler for
date formatting. This commit ensures that we do.
@rxaviers
Copy link
Copy Markdown
Member

rxaviers commented Mar 9, 2018

Thanks! ❤️
@rxaviers rxaviers merged commit b77f35f into globalizejs:master Mar 9, 2018
@rxaviers
Copy link
Copy Markdown
Member

rxaviers commented Mar 9, 2018

Published in https://github.com/globalizejs/globalize/releases/tag/1.4.0-alpha.1
@snyk-bot snyk-bot mentioned this pull request Nov 14, 2019
Open
@X-oss-byte X-oss-byte mentioned this pull request Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@SlexAxton @jsf-clabot @rxaviers