Number: Fix parser to handle empty string#691
Merged
Conversation
Contributor
|
That's a lot of regular expressions that are pretty hard to read. I can't tell where in the tokenizer update you're now handling the empty string. But it seems to be working, so, up to you to add more comments or not. |
Member
Author
|
Yeap, the regexps are starting to go crazy. The explanation I have is:
Any suggestion how to improve that please? |
Contributor
|
I've looked at those, but barely understand anything. I think I'd have to spend a few hours to understand the context, probably not quite worth it as this point. So, good to go :-) |
Member
Author
|
Sure thanks for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #682
Ref #292
Ref #353