Skip to content

Number: Fix parser to handle empty string#691

Merged
rxaviers merged 2 commits into
globalizejs:masterfrom
rxaviers:fix-682
Feb 23, 2017
Merged

Number: Fix parser to handle empty string#691
rxaviers merged 2 commits into
globalizejs:masterfrom
rxaviers:fix-682

Conversation

@rxaviers
Copy link
Copy Markdown
Member

Fixes #682
Ref #292
Ref #353

@jzaefferer
Copy link
Copy Markdown
Contributor

That's a lot of regular expressions that are pretty hard to read. I can't tell where in the tokenizer update you're now handling the empty string. But it seems to be working, so, up to you to add more comments or not.

@jzaefferer
Copy link
Copy Markdown
Contributor

I've looked at those, but barely understand anything. I think I'd have to spend a few hours to understand the context, probably not quite worth it as this point.

So, good to go :-)

@rxaviers
Copy link
Copy Markdown
Member Author

Sure thanks for the review

@rxaviers rxaviers merged commit fd84850 into globalizejs:master Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants