Dynamically augment availableFormats

[vectart]

fixes #271

[rxaviers]

Awesome! All I see for now are some style issues, which I'm going to comment inline.

[rxaviers]

cc @jzaefferer @scottgonzalez to comment on that

[jzaefferer]

As long as its in a separate commit. Should also enable caching, see, for example, qunitjs/qunit#835

[rxaviers]

@vectart please could you include this? ☝️

[rxaviers]

I assume you want to define pattern as a variable local to this function, so it's not mixed up with pattern defined by the parent function.

[rxaviers]

@vectart I left a couple of comments, please just let me know on any questions and thanks so far.

[vectart]

@rxaviers Thanks for the useful comments, I've updated PR according to them

[rxaviers]

Please, could you rebase on master (git rebase master)? I've updated jscs and it will help us to find the coding style issues.

[rxaviers]

It's ok using i instead of index here. :)

[rxaviers]

Interestingly, the augmentation for Globalize("en").formatDate(new Date(), {skeleton: "hhmm"}) worked just fine: '12:34 AM'. Although, it didn't work for Globalize("en").formatDate(new Date(), {skeleton: "HHmm"}): '0033' ('00:33'' expected). Please, could you check and also add this as a new test case?

[rxaviers]

Another worth doing test is checking against ICU... One difference I found is: EHmss gives 'Wed, 20:38:05' opposed to Wed 20:38:05 on ICU (http://demo.icu-project.org/icu4jweb/flexTest.jsp?pat=EHmss&_=en_US). The first one seems to have chosen by E alone and ms alone, then augmented ms into mss, then glued them. The second one seems to have chosen EHms, then augmented it into EHmss.

[rxaviers]

You might need use getBestMatchPattern() for each date and time before the type assignment above. For example, MMMMh should give July, 8 PM (type medium) instead of July at 8 PM (type long). Because, "MMMM" will be converted into "LLLL".

[rxaviers]

@vectart just let me know when you have progress, so we can land this fix. Thanks for your great work so far.

[Strate]

How about to use builtin new Intl.DateTimeFormatter().resolved.pattern to get best-fit pattern?