feat: port over to VSCode Webview UI Toolkit#18
Merged
Conversation
daviddossett
reviewed
Feb 1, 2022
hawkticehurst
approved these changes
Feb 1, 2022
hawkticehurst
left a comment
hawkticehurst
left a comment
There was a problem hiding this comment.
Beyond a question about semantic HTML usage and (potentially) missing attributes, this all (and especially toolkit usage) looks great!
|
Oh one more thing: it would be great if there was something to distinguish the webview tab from the raw YAML tab when you click the button to open the raw YAML. Currently, it's impossible to tell which is for the GUI versus not.
Updating the webview tab title to something like "Flat Editor: {file_name}" would be very helpful! |
added 17 commits
February 1, 2022 16:52
mattrothenberg
force-pushed
the
mr/webview-port
branch
from
d54b2c1 to
ee0088e
Compare
added 2 commits
February 1, 2022 17:06
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the webview code to use the newly exported React components from https://github.com/microsoft/vscode-webview-ui-toolkit.
While I've done my best not to modify any of the existing behavior/design, certain changes had to be made to accommodate the new set of components.
I've also gone ahead and updated us to the latest version of Tailwind and removed a bunch of unused code.