-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Go/Ruby/Python: Freeze quality queries in security-and-quality
.
#19891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Go/Ruby/Python: Freeze quality queries in security-and-quality
.
#19891
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR freezes the quality portion of security-and-quality query suites by introducing a dedicated selector and refactoring each language suite to use it.
- Add a new
security-and-frozen-quality-selectors.yml
to specify frozen quality queries alongside security ones - Update Ruby, Python, Go, JavaScript, Java, and C# suites to apply the frozen selector and list explicit quality query IDs
- Remove the previous inline include of security selectors from each suite
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
ruby/ql/src/codeql-suites/ruby-security-and-quality.qls | Swapped to frozen selector and added Ruby quality query IDs |
python/ql/src/codeql-suites/python-security-and-quality.qls | Swapped to frozen selector and added Python quality query IDs |
go/ql/src/codeql-suites/go-security-and-quality.qls | Swapped to frozen selector and added Go quality query IDs |
javascript/ql/src/codeql-suites/javascript-security-and-quality.qls | Swapped to frozen selector and removed old inline security includes |
java/ql/src/codeql-suites/java-security-and-quality.qls | Swapped to frozen selector and removed old inline security includes |
csharp/ql/src/codeql-suites/csharp-security-and-quality.qls | Swapped to frozen selector and removed old inline security includes |
misc/suite-helpers/security-and-frozen-quality-selectors.yml | New shared selector file for frozen quality and security queries |
Comments suppressed due to low confidence (2)
misc/suite-helpers/security-and-frozen-quality-selectors.yml:1
- [nitpick] The description is repetitive and could be simplified for clarity, e.g., "Selectors for non-quality queries in the security-and-quality suite for a language."
- description: Selectors for selecting the non-quality queries for the security-and-quality queries for a language
misc/suite-helpers/security-and-frozen-quality-selectors.yml:2
- [nitpick] The two separate include blocks for security problem selectors could be merged into a single block by combining the precision and severity filters to reduce duplication.
- include:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 Go and Java. (Presumably CI passing proves that the query suites haven't changed at all.)
Also re-factor the query suites to use a shared selector.