Rust: Cache DataFlow::Node.{toString,getLocation}
#19886
Merged
+18
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
rust/dataflow-caching
branch
from
84343de to
b70aa80
Compare
redsun82
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces extra caching, to avoid recomputing things in data flow query stages. I also identified an unfortunate recomputation as a result of
NodePublicbeingabstract; the compiler does not know thatNodePublicis in fact the same as the entire underlyingnewtype, so that resulted in a needless charpred with expensive recomputations.Reduces lines of DIL from 39K to 28.5K for the query stage of
CleartextLogging.ql. DCA confirms the DIL reduction for data flow queries.