Skip to content

cmake : use LLAMA_BUILD_NUMBER when defining LLAMA_INSTALL_VERSION #14362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

cmake : use LLAMA_BUILD_NUMBER when defining LLAMA_INSTALL_VERSION #14362

merged 1 commit into from
Jun 24, 2025

Conversation

mbaudier
Copy link
Contributor

Use the CMake variable LLAMA_BUILD_NUMBER (which can be set externally) instead of BUILD_NUMBER when defining LLAMA_INSTALL_VERSION.
@github-actions github-actions bot added the build Compilation issues label Jun 24, 2025
@ckastner ckastner self-requested a review June 24, 2025 11:52
ckastner
ckastner approved these changes Jun 24, 2025
View reviewed changes
Copy link
Collaborator

@ckastner ckastner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct. I overlooked this in #14167.
@ckastner ckastner merged commit c148cf1 into ggml-org:master Jun 24, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Compilation issues
2 participants
@mbaudier @ckastner