Wikipedia Scraping #1990
Merged
Wikipedia Scraping #1990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 4, 2023 16:00
BeautifulSoup and Flask Framework
Legal document reader using neuralDb
NitkarshChourasia
suggested changes
Oct 4, 2023
| @@ -0,0 +1,34 @@ | |||
| from thirdai import licensing, neural_db as ndb | |||
There was a problem hiding this comment.
Use docstring and comments, to make the program easily understandable to others as well as you.
|
|
||
| clear = Button(root, text="Clear", font=15, fg='black', bg="grey", width=10, command=clear_all) | ||
| clear.place(x=245, y=405) | ||
|
|
There was a problem hiding this comment.
Make it OOP based and KISS based.
if __name__ == "__main__":
main()
| for option in soup.find_all('option'): | ||
| language = option.text | ||
| symbol = option['lang'] | ||
| language_symbols[language] = symbol |
There was a problem hiding this comment.
Also, provide a proper README.md file, for other people, general people to understand what is this project is all about.
and cover basic aspects like:
- How to install
- How to uninstall
- How to use
etc...,
What are the key features, what are bugs, what to improve, what can be further refactored, etc..., just explaining your project in full length.
| </div> | ||
|
|
||
| <script src="https://code.jquery.com/jquery-3.5.1.slim.min.js"></script> | ||
| <script src="https://cdn.jsdelivr.net/npm/@popperjs/[email protected]/dist/umd/popper.min.js"></script> |
There was a problem hiding this comment.
Documentation and OOP based and KISS approach is missing everywhere.
MOST IMPORTANT:
README.md
and
Documentation is missing.
added 2 commits
October 4, 2023 19:08
NitkarshChourasia
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BeautifulSoup and Flask Framework