Skip to content

Add methods to implement native copy-to-clipboard functionality. #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 22, 2020

Conversation

VarunBarad
Copy link
Contributor

@VarunBarad VarunBarad commented Oct 22, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

This PR adds the native methods required to invoke the platform specific "copy url to clipboard" function.

To complete the integration, some code needs to be added to the https://dev.to also. Will create an issue for that over on thepracticaldev/dev.to with specific instructions as to what changes need to be made.

Issue with instructions for website: forem/forem#4543

Related Tickets & Documents

#58

@VarunBarad
Copy link
Contributor Author

@maestromac Can you check what is wrong with the license/cla check?
I have previously contributed to this repo and therefore have already agreed to the CLA. But for some reason here the license/cla check just isn't passing.

@VarunBarad VarunBarad closed this Oct 25, 2019
@VarunBarad VarunBarad reopened this Oct 25, 2019
@VarunBarad
Copy link
Contributor Author

@maestromac any help required?

@maestromac
Copy link
Contributor

Thank you again @VarunBarad and I apologize for not getting to this sooner. 🙇

This turns out to be everything we wanted but we got sidetracked and ended up re-doing the same thing. That said, we would like to take over this PR; to resolve to merge conflict and to include your "toast" implementation. Please let us know what you think.

@VarunBarad
Copy link
Contributor Author

VarunBarad commented Apr 22, 2020

@maestromac Please go ahead and include whatever you want, always happy to help 🙂
I only have one request, in the currently merged implementation of AndroidWebViewBridge the Context property is named mContext. Can you please rename it to context as hungarian notation is not advisable.

Copy link
Contributor

@fdocr fdocr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the help @VarunBarad and the recommendation on the context naming! I apologize too for the mishap and I'll be taking a look into your other PRs soon since I could be able to implement the necessary changes on the web repo 👍🏼

@fdocr fdocr merged commit cbfc9c7 into forem:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants