Skip to content

Dockerfile: Add zstd#853

Closed
zhijianli88 wants to merge 1 commit into
flatcar:mainfrom
zhijianli88:zstd
Closed

Dockerfile: Add zstd#853
zhijianli88 wants to merge 1 commit into
flatcar:mainfrom
zhijianli88:zstd

Conversation

@zhijianli88

Copy link
Copy Markdown

The ./run_local_tests.sh always expects this command to be existed. Add zstd to avoid the error messages

$ ./run_local_tests.sh arm64 2 cl.cloudinit.script

Using Mantle docker image 'ghcr.io/flatcar/mantle:git-ca80a2eaee4cc195ae6e17f9202c1d72e729d460'

Running qemu_uefi tests
git-ca80a2eaee4cc195ae6e17f9202c1d72e729d460: Pulling from flatcar/mantle
Digest: sha256:cd37c1ba21b8051eb2632e171d4f1f9bc7e91708883575343265d3d58940d5df
Status: Image is up to date for ghcr.io/flatcar/mantle:git-ca80a2eaee4cc195ae6e17f9202c1d72e729d460
zstd could not be found. unpacking container image may fail.
++++ Running qemu_uefi.sh inside TESTS/qemu_uefi ++++
++++ qemu_uefi.sh: Using existing /work/build/images/images/arm64-usr/latest/flatcar_production_image.bin for testing 4593.2.0+4-gbc1fd0010d (arm64) ++++
++++ qemu_uefi.sh: Using existing /work/build/images/images/arm64-usr/latest/flatcar_production_qemu_uefi_efi_code.qcow2 ++++
++++ qemu_uefi.sh: Using existing /work/build/images/images/arm64-usr/latest/flatcar_production_qemu_uefi_efi_vars.qcow2 ++++
=== RUN cl.cloudinit.script
--- PASS: cl.cloudinit.script (216.26s)
PASS, output in _kola_temp/qemu-2026-05-19-0704-13 git-ca80a2eaee4cc195ae6e17f9202c1d72e729d460: Pulling from flatcar/mantle Digest: sha256:cd37c1ba21b8051eb2632e171d4f1f9bc7e91708883575343265d3d58940d5df
Status: Image is up to date for ghcr.io/flatcar/mantle:git-ca80a2eaee4cc195ae6e17f9202c1d72e729d460
zstd could not be found. unpacking container image may fail.

[Title: describe the change in one sentence]

[ describe the change in 1 - 3 paragraphs ]

How to use

[ describe what reviewers need to do in order to validate this PR ]

Testing done

[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.
The ./run_local_tests.sh always expects this command to be existed.
Add zstd to avoid the error messages

 $ ./run_local_tests.sh arm64 2 cl.cloudinit.script
 =================================
 Using Mantle docker image 'ghcr.io/flatcar/mantle:git-ca80a2eaee4cc195ae6e17f9202c1d72e729d460'
 =================================
 Running qemu_uefi tests
 git-ca80a2eaee4cc195ae6e17f9202c1d72e729d460: Pulling from flatcar/mantle
 Digest: sha256:cd37c1ba21b8051eb2632e171d4f1f9bc7e91708883575343265d3d58940d5df
 Status: Image is up to date for ghcr.io/flatcar/mantle:git-ca80a2eaee4cc195ae6e17f9202c1d72e729d460
 zstd could not be found. unpacking container image may fail.
 ++++ Running qemu_uefi.sh inside __TESTS__/qemu_uefi ++++
 ++++ qemu_uefi.sh: Using existing /work/__build__/images/images/arm64-usr/latest/flatcar_production_image.bin for testing 4593.2.0+4-gbc1fd0010d (arm64) ++++
 ++++ qemu_uefi.sh: Using existing /work/__build__/images/images/arm64-usr/latest/flatcar_production_qemu_uefi_efi_code.qcow2 ++++
 ++++ qemu_uefi.sh: Using existing /work/__build__/images/images/arm64-usr/latest/flatcar_production_qemu_uefi_efi_vars.qcow2 ++++
 === RUN   cl.cloudinit.script
 --- PASS: cl.cloudinit.script (216.26s)
 PASS, output in _kola_temp/qemu-2026-05-19-0704-13                                                                                                                                                                                     git-ca80a2eaee4cc195ae6e17f9202c1d72e729d460: Pulling from flatcar/mantle                                                                                                                                                              Digest: sha256:cd37c1ba21b8051eb2632e171d4f1f9bc7e91708883575343265d3d58940d5df
 Status: Image is up to date for ghcr.io/flatcar/mantle:git-ca80a2eaee4cc195ae6e17f9202c1d72e729d460
 zstd could not be found. unpacking container image may fail.

Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
@zhijianli88 zhijianli88 requested a review from a team as a code owner May 19, 2026 07:55
@chewi

chewi commented May 19, 2026

Copy link
Copy Markdown
Contributor

I believe this error comes from the scripts repo where run_local_tests.sh is run from, so adding zstd to the Mantle container won't make any difference. Even then, I think the error is harmless because we're not unpacking the image in this context.

@chewi chewi closed this May 19, 2026
@zhijianli88

Copy link
Copy Markdown
Author

I believe this error comes from the scripts repo where run_local_tests.sh is run from, so adding zstd to the Mantle container won't make any difference.

Not exactly. The run_local_tests.sh script launches the Mantle container to run the kola tests.

Even then, I think the error is harmless because we're not unpacking the image in this context.

That's true. I was also wondering whether I should update the related script in the scripts repo. However, this script is a dependency for many other tools, so I'm a bit hesitant to change it.

scripts$ git grep -A2 'command -v zstd'
ci-automation/ci-config.env:if ! command -v zstd > /dev/null; then
ci-automation/ci-config.env-  # we require zstd and it is included by default on flatcar
ci-automation/ci-config.env-  echo >&2 "zstd could not be found. unpacking container image may fail."

@chewi

chewi commented May 20, 2026

Copy link
Copy Markdown
Contributor

Ah okay, on closer inspection, the check is done both outside and inside the container since the scripts repo gets mounted inside it. zstd is only needed when building Flatcar though, not when running the tests. The check can probably be dropped, as it's more confusing than helpful, or maybe it could be moved to a better location.

zhijianli88 added a commit to zhijianli88/scripts that referenced this pull request May 21, 2026
When running `./run_local_tests.sh`, a warning is printed if `zstd` is
not found in the host environment:

  $ ./run_local_tests.sh arm64 2 cl.cloudinit.script
  ...
  zstd could not be found. unpacking container image may fail.
  ...

This check is performed because `ci-config.env` is sourced by the script.
However, the `run_local_tests.sh` workflow itself does not depend on `zstd`.

The `zstd` command is required for building Flatcar[1], but that
process runs inside the Flatcar SDK container, which is guaranteed to
have `zstd` installed. The check on the host running the local tests is
therefore redundant and produces confusing noise for developers.

This patch removes the check to eliminate the spurious warning.

[1] flatcar/mantle#853 (comment)
Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
@zhijianli88

Copy link
Copy Markdown
Author

Ah okay, on closer inspection, the check is done both outside and inside the container since the scripts repo gets mounted inside it. zstd is only needed when building Flatcar though, not when running the tests. The check can probably be dropped, as it's more confusing than helpful, or maybe it could be moved to a better location.

Understood. I folded this update to scripts: flatcar/scripts@505fa4f

zhijianli88 added a commit to zhijianli88/scripts that referenced this pull request May 22, 2026
When running `./run_local_tests.sh`, a warning is printed if `zstd` is
not found in the host environment:

  $ ./run_local_tests.sh arm64 2 cl.cloudinit.script
  ...
  zstd could not be found. unpacking container image may fail.
  ...

This check is performed because `ci-config.env` is sourced by the script.
However, the `run_local_tests.sh` workflow itself does not depend on `zstd`.

The `zstd` command is required for building Flatcar[1], but that
process runs inside the Flatcar SDK container, which is guaranteed to
have `zstd` installed. The check on the host running the local tests is
therefore redundant and produces confusing noise for developers.

This patch removes the check to eliminate the spurious warning.

[1] flatcar/mantle#853 (comment)
Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
zhijianli88 added a commit to zhijianli88/scripts that referenced this pull request May 22, 2026
When running `./run_local_tests.sh`, a warning is printed if `zstd` is
not found in the host environment:

  $ ./run_local_tests.sh arm64 2 cl.cloudinit.script
  ...
  zstd could not be found. unpacking container image may fail.
  ...

This check is performed because `ci-config.env` is sourced by the script.
However, the `run_local_tests.sh` workflow itself does not depend on `zstd`.

The `zstd` command is required for building Flatcar[1], but that
process runs inside the Flatcar SDK container, which is guaranteed to
have `zstd` installed. The check on the host running the local tests is
therefore redundant and produces confusing noise for developers.

This patch removes the check to eliminate the spurious warning.

[1] flatcar/mantle#853 (comment)
Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
zhijianli88 added a commit to zhijianli88/scripts that referenced this pull request Jun 5, 2026
When running `./run_local_tests.sh`, a warning is printed if `zstd` is
not found in the host environment:

  $ ./run_local_tests.sh arm64 2 cl.cloudinit.script
  ...
  zstd could not be found. unpacking container image may fail.
  ...

This check is performed because `ci-config.env` is sourced by the script.
However, the `run_local_tests.sh` workflow itself does not depend on `zstd`.

The `zstd` command is required for building Flatcar[1], but that
process runs inside the Flatcar SDK container, which is guaranteed to
have `zstd` installed. The check on the host running the local tests is
therefore redundant and produces confusing noise for developers.

This patch removes the check to eliminate the spurious warning.

[1] flatcar/mantle#853 (comment)
Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants