Dockerfile: Add zstd#853
Conversation
The ./run_local_tests.sh always expects this command to be existed. Add zstd to avoid the error messages $ ./run_local_tests.sh arm64 2 cl.cloudinit.script ================================= Using Mantle docker image 'ghcr.io/flatcar/mantle:git-ca80a2eaee4cc195ae6e17f9202c1d72e729d460' ================================= Running qemu_uefi tests git-ca80a2eaee4cc195ae6e17f9202c1d72e729d460: Pulling from flatcar/mantle Digest: sha256:cd37c1ba21b8051eb2632e171d4f1f9bc7e91708883575343265d3d58940d5df Status: Image is up to date for ghcr.io/flatcar/mantle:git-ca80a2eaee4cc195ae6e17f9202c1d72e729d460 zstd could not be found. unpacking container image may fail. ++++ Running qemu_uefi.sh inside __TESTS__/qemu_uefi ++++ ++++ qemu_uefi.sh: Using existing /work/__build__/images/images/arm64-usr/latest/flatcar_production_image.bin for testing 4593.2.0+4-gbc1fd0010d (arm64) ++++ ++++ qemu_uefi.sh: Using existing /work/__build__/images/images/arm64-usr/latest/flatcar_production_qemu_uefi_efi_code.qcow2 ++++ ++++ qemu_uefi.sh: Using existing /work/__build__/images/images/arm64-usr/latest/flatcar_production_qemu_uefi_efi_vars.qcow2 ++++ === RUN cl.cloudinit.script --- PASS: cl.cloudinit.script (216.26s) PASS, output in _kola_temp/qemu-2026-05-19-0704-13 git-ca80a2eaee4cc195ae6e17f9202c1d72e729d460: Pulling from flatcar/mantle Digest: sha256:cd37c1ba21b8051eb2632e171d4f1f9bc7e91708883575343265d3d58940d5df Status: Image is up to date for ghcr.io/flatcar/mantle:git-ca80a2eaee4cc195ae6e17f9202c1d72e729d460 zstd could not be found. unpacking container image may fail. Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
|
I believe this error comes from the scripts repo where |
Not exactly. The run_local_tests.sh script launches the Mantle container to run the kola tests.
That's true. I was also wondering whether I should update the related script in the scripts repo. However, this script is a dependency for many other tools, so I'm a bit hesitant to change it. |
|
Ah okay, on closer inspection, the check is done both outside and inside the container since the scripts repo gets mounted inside it. zstd is only needed when building Flatcar though, not when running the tests. The check can probably be dropped, as it's more confusing than helpful, or maybe it could be moved to a better location. |
When running `./run_local_tests.sh`, a warning is printed if `zstd` is not found in the host environment: $ ./run_local_tests.sh arm64 2 cl.cloudinit.script ... zstd could not be found. unpacking container image may fail. ... This check is performed because `ci-config.env` is sourced by the script. However, the `run_local_tests.sh` workflow itself does not depend on `zstd`. The `zstd` command is required for building Flatcar[1], but that process runs inside the Flatcar SDK container, which is guaranteed to have `zstd` installed. The check on the host running the local tests is therefore redundant and produces confusing noise for developers. This patch removes the check to eliminate the spurious warning. [1] flatcar/mantle#853 (comment) Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Understood. I folded this update to scripts: flatcar/scripts@505fa4f |
When running `./run_local_tests.sh`, a warning is printed if `zstd` is not found in the host environment: $ ./run_local_tests.sh arm64 2 cl.cloudinit.script ... zstd could not be found. unpacking container image may fail. ... This check is performed because `ci-config.env` is sourced by the script. However, the `run_local_tests.sh` workflow itself does not depend on `zstd`. The `zstd` command is required for building Flatcar[1], but that process runs inside the Flatcar SDK container, which is guaranteed to have `zstd` installed. The check on the host running the local tests is therefore redundant and produces confusing noise for developers. This patch removes the check to eliminate the spurious warning. [1] flatcar/mantle#853 (comment) Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
When running `./run_local_tests.sh`, a warning is printed if `zstd` is not found in the host environment: $ ./run_local_tests.sh arm64 2 cl.cloudinit.script ... zstd could not be found. unpacking container image may fail. ... This check is performed because `ci-config.env` is sourced by the script. However, the `run_local_tests.sh` workflow itself does not depend on `zstd`. The `zstd` command is required for building Flatcar[1], but that process runs inside the Flatcar SDK container, which is guaranteed to have `zstd` installed. The check on the host running the local tests is therefore redundant and produces confusing noise for developers. This patch removes the check to eliminate the spurious warning. [1] flatcar/mantle#853 (comment) Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
When running `./run_local_tests.sh`, a warning is printed if `zstd` is not found in the host environment: $ ./run_local_tests.sh arm64 2 cl.cloudinit.script ... zstd could not be found. unpacking container image may fail. ... This check is performed because `ci-config.env` is sourced by the script. However, the `run_local_tests.sh` workflow itself does not depend on `zstd`. The `zstd` command is required for building Flatcar[1], but that process runs inside the Flatcar SDK container, which is guaranteed to have `zstd` installed. The check on the host running the local tests is therefore redundant and produces confusing noise for developers. This patch removes the check to eliminate the spurious warning. [1] flatcar/mantle#853 (comment) Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
The ./run_local_tests.sh always expects this command to be existed. Add zstd to avoid the error messages
$ ./run_local_tests.sh arm64 2 cl.cloudinit.script
Using Mantle docker image 'ghcr.io/flatcar/mantle:git-ca80a2eaee4cc195ae6e17f9202c1d72e729d460'
Running qemu_uefi tests
git-ca80a2eaee4cc195ae6e17f9202c1d72e729d460: Pulling from flatcar/mantle
Digest: sha256:cd37c1ba21b8051eb2632e171d4f1f9bc7e91708883575343265d3d58940d5df
Status: Image is up to date for ghcr.io/flatcar/mantle:git-ca80a2eaee4cc195ae6e17f9202c1d72e729d460
zstd could not be found. unpacking container image may fail.
++++ Running qemu_uefi.sh inside TESTS/qemu_uefi ++++
++++ qemu_uefi.sh: Using existing /work/build/images/images/arm64-usr/latest/flatcar_production_image.bin for testing 4593.2.0+4-gbc1fd0010d (arm64) ++++
++++ qemu_uefi.sh: Using existing /work/build/images/images/arm64-usr/latest/flatcar_production_qemu_uefi_efi_code.qcow2 ++++
++++ qemu_uefi.sh: Using existing /work/build/images/images/arm64-usr/latest/flatcar_production_qemu_uefi_efi_vars.qcow2 ++++
=== RUN cl.cloudinit.script
--- PASS: cl.cloudinit.script (216.26s)
PASS, output in _kola_temp/qemu-2026-05-19-0704-13 git-ca80a2eaee4cc195ae6e17f9202c1d72e729d460: Pulling from flatcar/mantle Digest: sha256:cd37c1ba21b8051eb2632e171d4f1f9bc7e91708883575343265d3d58940d5df
Status: Image is up to date for ghcr.io/flatcar/mantle:git-ca80a2eaee4cc195ae6e17f9202c1d72e729d460
zstd could not be found. unpacking container image may fail.
[Title: describe the change in one sentence]
[ describe the change in 1 - 3 paragraphs ]
How to use
[ describe what reviewers need to do in order to validate this PR ]
Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.