fix: use isMfaEnabled configuration flag with disabled button state and tooltip#2297
Merged
Conversation
…er.Google - The `applicationId` parameter has been removed from the `AuthProvider.Facebook` constructor. Configuration values (`facebook_application_id`, `facebook_login_protocol_scheme`, and `facebook_client_token`) are now exclusively read from `strings.xml`. - The `serverClientId` for the Google provider is now automatically populated from `R.string.default_web_client_id` if it is not explicitly provided. - Added validation to ensure `facebook_client_token` and `facebook_login_protocol_scheme` are configured in `strings.xml`. - Updated tests to use resource files for provider configuration instead of constructor arguments. - Updated `README.md` to reflect the new configuration requirements, including adding `facebook_client_token`.
…during sign-in - Add filterByAuthorizedAccounts and autoSelectEnabled properties to AuthProvider.Google
…se configuration to custom authenticated content
…irebaseUI-Android into fix-provider-config
…ebaseUI-Android into fix-mfa-config
Lyokone
approved these changes
Jan 2, 2026
Merged
thatfiredev
pushed a commit
that referenced
this pull request
Mar 13, 2026
…nd tooltip (#2297) * fix: initialize serverClientId to default_web_client_id in AuthProvider.Google - The `applicationId` parameter has been removed from the `AuthProvider.Facebook` constructor. Configuration values (`facebook_application_id`, `facebook_login_protocol_scheme`, and `facebook_client_token`) are now exclusively read from `strings.xml`. - The `serverClientId` for the Google provider is now automatically populated from `R.string.default_web_client_id` if it is not explicitly provided. - Added validation to ensure `facebook_client_token` and `facebook_login_protocol_scheme` are configured in `strings.xml`. - Updated tests to use resource files for provider configuration instead of constructor arguments. - Updated `README.md` to reflect the new configuration requirements, including adding `facebook_client_token`. * fix: fallback to all Google accounts if no authorized accounts found during sign-in - Add filterByAuthorizedAccounts and autoSelectEnabled properties to AuthProvider.Google * fix: disable Manage MFA button and show tooltip when MFA is disabled * fix: implement MFA configuration disabled state with tooltip and expose configuration to custom authenticated content * fix CI * test: ignore flaky onManageMfa test due to CI timing issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
isMfaEnabledconfiguration flagfui_mfa_disabled_tooltipstring resource to all 85 language filesFixes #2296