Skip to content

test: rewrite vehicle#469

Merged
ST-DDT merged 2 commits into
mainfrom
test-rewrite-vehicle
Feb 15, 2022
Merged

test: rewrite vehicle#469
ST-DDT merged 2 commits into
mainfrom
test-rewrite-vehicle

Conversation

@Shinigami92

@Shinigami92 Shinigami92 commented Feb 11, 2022 •
edited by ST-DDT
Loading

Copy link
Copy Markdown
Member

No description provided.

@Shinigami92 Shinigami92 self-assigned this Feb 11, 2022
@Shinigami92 Shinigami92 mentioned this pull request Feb 11, 2022
Closed
@Shinigami92 Shinigami92 added the p: 2-high Fix main branch label Feb 11, 2022
@Shinigami92 Shinigami92 marked this pull request as ready for review February 11, 2022 14:54
@Shinigami92 Shinigami92 requested a review from a team as a code owner February 11, 2022 14:54
@Shinigami92 Shinigami92 requested a review from ST-DDT February 11, 2022 14:54
@codecov

codecov Bot commented Feb 11, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #469 (6e9f6fd) into main (06dbf6d) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
- Coverage   99.34%   99.34%   -0.01%     
==========================================
  Files        1919     1919              
  Lines      176173   176173              
  Branches      902      902              
==========================================
- Hits       175017   175016       -1     
- Misses       1100     1101       +1     
  Partials       56       56
Impacted Files Coverage Δ
src/helpers.ts 99.39% <0.00%> (-0.16%) ⬇️
ST-DDT
ST-DDT requested changes Feb 11, 2022
View reviewed changes
Comment thread src/definitions/vehicle.ts Outdated
@Shinigami92 Shinigami92 requested a review from ST-DDT February 11, 2022 15:08
ST-DDT
ST-DDT requested changes Feb 11, 2022
View reviewed changes
Comment thread src/locales/en/vehicle/index.ts Outdated
@Shinigami92 Shinigami92 removed the p: 2-high Fix main branch label Feb 11, 2022
@Shinigami92 Shinigami92 marked this pull request as draft February 11, 2022 15:28
@Shinigami92 Shinigami92 added the s: on hold Blocked by something or frozen to avoid conflicts label Feb 11, 2022
@ST-DDT ST-DDT mentioned this pull request Feb 12, 2022
Merged
@Shinigami92 Shinigami92 removed the s: on hold Blocked by something or frozen to avoid conflicts label Feb 14, 2022
@Shinigami92 Shinigami92 marked this pull request as ready for review February 14, 2022 16:48
@Shinigami92 Shinigami92 requested review from a team and ST-DDT February 14, 2022 16:48
@ST-DDT ST-DDT requested a review from a team February 14, 2022 16:56
@ST-DDT ST-DDT merged commit fceb128 into main Feb 15, 2022
@ST-DDT ST-DDT deleted the test-rewrite-vehicle branch February 15, 2022 14:48
demipel8 pushed a commit to demipel8/faker that referenced this pull request Mar 11, 2022
@Shinigami92 @demipel8
test: rewrite vehicle (faker-js#469)
8dc2269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: test

3 participants

@Shinigami92 @ST-DDT @prisis