Skip to content

feat: add more arabic names datasets#368

Merged
ST-DDT merged 13 commits into
faker-js:mainfrom
wael-fadlallah:arabicDS
Apr 19, 2022
Merged

feat: add more arabic names datasets#368
ST-DDT merged 13 commits into
faker-js:mainfrom
wael-fadlallah:arabicDS

Conversation

@wael-fadlallah

Copy link
Copy Markdown
Contributor

No description provided.

@wael-fadlallah wael-fadlallah requested a review from a team as a code owner January 30, 2022 10:54
@Shinigami92 Shinigami92 added the p: 1-normal Nothing urgent label Jan 30, 2022
@Shinigami92 Shinigami92 added this to the v6.2 - New small features milestone Jan 30, 2022
@ejcheng ejcheng added the c: feature Request for new feature label Jan 30, 2022
@Shinigami92 Shinigami92 added c: locale Permutes locale definitions and removed c: feature Request for new feature labels Mar 18, 2022
@ejcheng ejcheng added the needs rebase There is a merge conflict label Mar 19, 2022
@Shinigami92

Copy link
Copy Markdown
Member

@wael-fadlallah Please rebase and resolve any conflicts

@codecov

codecov Bot commented Apr 18, 2022

Copy link
Copy Markdown

Codecov Report

Merging #368 (0b485ef) into main (069f4d1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##             main     #368    +/-   ##
========================================
  Coverage   99.34%   99.34%            
========================================
  Files        1921     1921            
  Lines      179183   179504   +321     
  Branches      898      898            
========================================
+ Hits       178006   178327   +321     
  Misses       1121     1121            
  Partials       56       56            
Impacted Files Coverage Δ
src/locales/ar/name/male_first_name.ts 100.00% <100.00%> (ø)
@Shinigami92 Shinigami92 removed the needs rebase There is a merge conflict label Apr 18, 2022
@Shinigami92 Shinigami92 requested review from a team April 18, 2022 08:34

@ST-DDT ST-DDT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me format wise.

FYI: We cannot merge this yet due to a broken build pipeline.
We will try to fix it this week.

@ST-DDT ST-DDT enabled auto-merge (squash) April 19, 2022 19:32
@ST-DDT ST-DDT merged commit f824f9d into faker-js:main Apr 19, 2022
@wael-fadlallah wael-fadlallah deleted the arabicDS branch October 14, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: locale Permutes locale definitions p: 1-normal Nothing urgent

6 participants