Skip to content

chore: Migrate en to ts#236

Closed
doughlass wants to merge 2 commits into
faker-js:mainfrom
doughlass:migrate-en-to-ts
Closed

chore: Migrate en to ts#236
doughlass wants to merge 2 commits into
faker-js:mainfrom
doughlass:migrate-en-to-ts

Conversation

@doughlass

Copy link
Copy Markdown
Contributor

Migrated the en directory of locales to ts and fixed broken type definitions and added new ones.

@doughlass doughlass requested a review from a team as a code owner January 19, 2022 21:42
@netlify

netlify Bot commented Jan 19, 2022

Copy link
Copy Markdown

✔️ Deploy Preview for vigilant-wescoff-04e480 ready!

🔨 Explore the source changes: 443176b

🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61e885c832ee7a0008c32837

😎 Browse the preview: https://deploy-preview-236--vigilant-wescoff-04e480.netlify.app

@doughlass doughlass changed the title Migrate en to ts chore: Migrate en to ts Jan 19, 2022
@ejcheng ejcheng added the c: chore PR that doesn't affect the runtime behavior label Jan 19, 2022
@ST-DDT

ST-DDT commented Jan 19, 2022

Copy link
Copy Markdown
Member

Please note, that I started #238 to automatically migrate these files.

@Shinigami92

Copy link
Copy Markdown
Member

@doughlass please wait until @ST-DDT's PR is merged and then apply your improvements
It would be anyway a good idea to split migrations from adding enhancements

@Shinigami92

Copy link
Copy Markdown
Member

... and fixed broken type definitions and added new ones.

Could you please open a new PR? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: chore PR that doesn't affect the runtime behavior

4 participants