Skip to content

fix: re-enable failing test on windows#224

Closed
ST-DDT wants to merge 1 commit into
faker-js:mainfrom
ST-DDT:fix/issue223
Closed

fix: re-enable failing test on windows#224
ST-DDT wants to merge 1 commit into
faker-js:mainfrom
ST-DDT:fix/issue223

Conversation

@ST-DDT

@ST-DDT ST-DDT commented Jan 18, 2022

Copy link
Copy Markdown
Member

I tried running the tests in my fork and it worked pretty fine when running there.
https://github.com/ST-DDT/faker/pull/1
@netlify

netlify Bot commented Jan 18, 2022 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for vigilant-wescoff-04e480 ready!

🔨 Explore the source changes: 1ee40db

🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61e86578c288e400088aef27

😎 Browse the preview: https://deploy-preview-224--vigilant-wescoff-04e480.netlify.app
@Shinigami92 Shinigami92 self-requested a review January 18, 2022 22:33
@Shinigami92 Shinigami92 added c: bug Something isn't working p: 2-high Fix main branch c: test labels Jan 18, 2022
@Shinigami92 Shinigami92 linked an issue Jan 18, 2022 that may be closed by this pull request
Test: Fix failing test finance in win32 system #223
Closed
@ST-DDT

ST-DDT commented Jan 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

For some reason this seems to be working fine now.
Maybe we should wait a bit and rerun the pipeline later to ensure this isn't a flaky test result.
(I had a similar problem with one of my java applications before. The docker host ran into performance + port issues causing the tests to fail, but those failures were distributed more randomly)
Shinigami92
Shinigami92 previously approved these changes Jan 18, 2022
View reviewed changes
poyea
poyea previously approved these changes Jan 19, 2022
View reviewed changes

@poyea poyea left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintainers can re-run the jobs in the Actions tab in the future, if it's failing for some weird reasons (considering there's a large amount of individual tests).
@ST-DDT ST-DDT dismissed stale reviews from poyea and Shinigami92 via 8efe060 January 19, 2022 19:14
@ST-DDT ST-DDT requested a review from a team as a code owner January 19, 2022 19:14
@ST-DDT

ST-DDT commented Jan 19, 2022

Copy link
Copy Markdown
Member Author

FFR: The test is failing at 19:26:27 UTC
@ST-DDT ST-DDT mentioned this pull request Jan 20, 2022
Merged
6 tasks
@ST-DDT

ST-DDT commented Jan 20, 2022

Copy link
Copy Markdown
Member Author

FFR: The test succeeded at 09:21 MEZ
@ST-DDT

ST-DDT commented Jan 20, 2022

Copy link
Copy Markdown
Member Author

This probably gets obsolete once #235 is merged.
@ST-DDT ST-DDT mentioned this pull request Jan 20, 2022
Merged
@ST-DDT ST-DDT deleted the fix/issue223 branch January 21, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: bug Something isn't working c: test p: 2-high Fix main branch

3 participants

@ST-DDT @Shinigami92 @poyea