feat(locale): add direction to ja#2191
Merged
Merged
Conversation
Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2191 +/- ##
=======================================
Coverage 99.59% 99.60%
=======================================
Files 2621 2622 +1
Lines 245476 245479 +3
Branches 1151 1153 +2
=======================================
+ Hits 244483 244505 +22
+ Misses 966 947 -19
Partials 27 27
|
ejcheng
approved these changes
May 31, 2023
xDivisionByZerox
approved these changes
Jun 1, 2023
xDivisionByZerox
left a comment
Member
There was a problem hiding this comment.
Thank you for your contribution!
ST-DDT
approved these changes
Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I was trying to use Faker to generate dummy directions but I found the
jalocal is missing.Therefore, I have added it like
faker/src/locales/en/location/direction.ts
Lines 1 to 10 in 27a8ff7
Thank you in advance.