feat: bundle faker with microbundle#217
Conversation
|
❌ Deploy Preview for vigilant-wescoff-04e480 failed. 🔨 Explore the source changes: 228fa50 🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61eb3de4aebefc000765950f |
|
Yeah, after both are merged this should work :) |
|
I'd like to block on this. I don't know why we would drop support for export default and make this a breaking change. |
We don't 👀 |
|
Spoke with Shini and I understand what this is about now 👍🏻 |
dad5fcd to
1a6e2fb
Compare
|
@prisis try to at these lines to our workflow ci.yml |
48c6861 to
73b57f6
Compare
|
We also need to add dist and remove lib to/from some ignore files |
73b57f6 to
ba3697b
Compare
| "unpkg": "./dist/faker.umd.js", | ||
| "files": [ | ||
| "CHANGELOG.md", | ||
| "CHANGELOG_old.md", |
There was a problem hiding this comment.
Here in files, we can remove
"index.d.ts",
"index.js",
"lib",
"locale",
| "vitepress": "^0.21.4", | ||
| "vitest": "~0.1.24" | ||
| "vitest": "~0.1.24", | ||
| "microbundle": "^0.14.2" |
There was a problem hiding this comment.
Please move it up to sorted position
Also it would be good to use ~ instead of ^
The use rm -Rf node_modules pnpm-lock.yaml && pnpm install and commit both files
| @@ -84,7 +91,8 @@ | |||
| "vinyl-transform": "^1.0.0", | |||
There was a problem hiding this comment.
We should remove some dependencies:
- browserify
- gulp
- gulp-gh-pages
- gulp-rename
- gulp-uglify
- optimist
- ink-docstrap
- through2
- vinyl-buffer
- vinyl-source-stream
- vinyl-transform
There was a problem hiding this comment.
I think we can also remove the build folder completely
(and all references to that, like in readme/docs and ignore files)
|
This PR may be superseded by #257 |
No description provided.