Skip to content

fix(locale): fix en_HK city_pattern#2105

Merged
ST-DDT merged 2 commits into
faker-js:nextfrom
matthewmayer:chore/en-hk-city
Apr 29, 2023
Merged

fix(locale): fix en_HK city_pattern#2105
ST-DDT merged 2 commits into
faker-js:nextfrom
matthewmayer:chore/en-hk-city

Conversation

@matthewmayer

Copy link
Copy Markdown
Contributor

Due to merges of #2083 and #2094 en_HK ended up without a valid city_pattern
file

@matthewmayer matthewmayer requested a review from a team as a code owner April 28, 2023 14:16
@matthewmayer matthewmayer self-assigned this Apr 28, 2023
@matthewmayer matthewmayer added c: chore PR that doesn't affect the runtime behavior c: locale Permutes locale definitions labels Apr 28, 2023
@matthewmayer matthewmayer changed the title chore(locale): fix en_HK city_pattern fix(locale): fix en_HK city_pattern Apr 28, 2023
@codecov

codecov Bot commented Apr 28, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2105 (06ba6bc) into next (789c8a2) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2105      +/-   ##
==========================================
- Coverage   99.59%   99.58%   -0.01%     
==========================================
  Files        2566     2567       +1     
  Lines      243349   243352       +3     
  Branches     1252     1247       -5     
==========================================
- Hits       242372   242354      -18     
- Misses        950      971      +21     
  Partials       27       27              
Impacted Files Coverage Δ
src/locales/en_HK/location/city_name.ts 100.00% <ø> (ø)
src/locales/en_HK/location/city_pattern.ts 100.00% <100.00%> (ø)
src/locales/en_HK/location/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT requested review from a team April 28, 2023 22:47
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Apr 28, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) April 29, 2023 16:27
@ST-DDT ST-DDT merged commit 75e4892 into faker-js:next Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: chore PR that doesn't affect the runtime behavior c: locale Permutes locale definitions p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug

3 participants