Skip to content

fix(person): change fullName to use name patterns #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ST-DDT merged 28 commits into from
Feb 2, 2023
Merged

fix(person): change fullName to use name patterns #1637

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
77e0bd4
fix(person): change fullName to use name patterns
matthewmayer Dec 6, 2022
3946178
fix(person): temp disable tests, add gendered prefixes in en
matthewmayer Dec 6, 2022
5c54896
fix(person): fix snapshot tests
matthewmayer Dec 7, 2022
6283b58
fix(person): bring back test
matthewmayer Dec 7, 2022
c285157
fix(person): add weightedArrayElement helper
matthewmayer Dec 7, 2022
753fedc
fix(person): fix nl
matthewmayer Dec 7, 2022
ff786c9
fix(person): fix nl and de_AT
matthewmayer Dec 7, 2022
f462314
fix(person): warnings
matthewmayer Dec 7, 2022
8ecdff5
Merge branch 'next' into chore/fullname-name-patterns
Dec 11, 2022
8abb959
Merge branch 'next' into chore/fullname-name-patterns
matthewmayer Jan 2, 2023
284ad8c
migrate to new weightedArray method
matthewmayer Jan 2, 2023
a802269
rv prefix changes
matthewmayer Jan 2, 2023
9158378
update snapshots
matthewmayer Jan 2, 2023
0a18c4c
fix lint
matthewmayer Jan 2, 2023
f78138c
Merge branch 'next' into chore/fullname-name-patterns
Jan 6, 2023
dd81694
change name patterns to use camelCase
matthewmayer Jan 6, 2023
165224f
remove nobility title prefix for de
matthewmayer Jan 7, 2023
c749b29
Merge branch 'next' into chore/fullname-name-patterns
matthewmayer Jan 10, 2023
93a49ff
Merge branch 'next' into chore/fullname-name-patterns
ST-DDT Jan 10, 2023
6ea472d
revert changes to middle_name in de, de_AT, nl
matthewmayer Jan 28, 2023
4ed2219
Merge branch 'next' into chore/fullname-name-patterns
Jan 28, 2023
b0319d7
rv tussenvoegsel in nl
matthewmayer Jan 28, 2023
d6b6356
parse options first, remove unused gender substitution, update tests
matthewmayer Jan 28, 2023
1c648d6
Merge branch 'next' into chore/fullname-name-patterns
ST-DDT Jan 29, 2023
7826f21
Merge branch 'next' into chore/fullname-name-patterns
ST-DDT Jan 30, 2023
fcff0c1
Merge branch 'next' into chore/fullname-name-patterns
ST-DDT Feb 1, 2023
c3ccd26
fix new lint error
matthewmayer Feb 2, 2023
cea078e
Merge branch 'next' into chore/fullname-name-patterns
ST-DDT Feb 2, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(person): fix snapshot tests
  • Loading branch information
@matthewmayer
matthewmayer committed Dec 7, 2022
commit 5c548964786e21f9cb93014df9c09e659150b201
4 changes: 2 additions & 2 deletions test/__snapshots__/person.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ exports[`person > 42 > middleName > with sex 1`] = `"Houston"`;

exports[`person > 42 > prefix > noArgs 1`] = `"Mrs."`;

exports[`person > 42 > prefix > with sex 1`] = `"Mrs."`;
exports[`person > 42 > prefix > with sex 1`] = `"Mr."`;

exports[`person > 42 > sex > noArgs 1`] = `"female"`;

Expand Down Expand Up @@ -130,7 +130,7 @@ exports[`person > 1337 > middleName > with sex 1`] = `"Ethan"`;

exports[`person > 1337 > prefix > noArgs 1`] = `"Mrs."`;

exports[`person > 1337 > prefix > with sex 1`] = `"Mrs."`;
exports[`person > 1337 > prefix > with sex 1`] = `"Mr."`;

exports[`person > 1337 > sex > noArgs 1`] = `"female"`;

Expand Down