fix: fix bicycle_types files being named incorrectly#477
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #477 +/- ##
==========================================
- Coverage 99.34% 99.34% -0.01%
==========================================
Files 1919 1919
Lines 176291 176291
Branches 904 902 -2
==========================================
- Hits 175136 175134 -2
- Misses 1099 1101 +2
Partials 56 56
|
Shinigami92
approved these changes
Feb 12, 2022
prisis
approved these changes
Feb 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #471
I decided to rename the files to
bicycle_typesinstead of changing the definition tobicycle, because for the other vehicles there is already thetypemodule (which probably should be calledvehicle_typesorcar_typesinstead).This fixes a bug that was already present in 5.5.3, but blocks writing working tests for the vehicle module. See also #469.