Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

[ASControlNode] Respect hitTestSlop when determining if a tracked touch is inside#2896

Merged
Adlai-Holler merged 1 commit into
facebookarchive:masterfrom
GitGadd:GDASControlNodeExpandedBounds
Jan 13, 2017
Merged

[ASControlNode] Respect hitTestSlop when determining if a tracked touch is inside#2896
Adlai-Holler merged 1 commit into
facebookarchive:masterfrom
GitGadd:GDASControlNodeExpandedBounds

Conversation

@GitGadd

@GitGadd GitGadd commented Jan 13, 2017

Copy link
Copy Markdown
Contributor

Proposed fix for #2877. It takes the hitTestSlop into account when ASControlNode considers if a tracked touch is 'inside'.

This is my first PR here; Let me know if anything is off!

@Adlai-Holler Adlai-Holler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GitGadd Thanks for the diff!

@Adlai-Holler

Copy link
Copy Markdown
Contributor

Jenkins, test this please

@Adlai-Holler

Copy link
Copy Markdown
Contributor

Alrighty, thanks for a great diff @GitGadd, I hope to see you around more man!

@Adlai-Holler Adlai-Holler merged commit f52bc78 into facebookarchive:master Jan 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

3 participants