refactor: change react promise status type #31623
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ifabriciorodrigues
force-pushed
the
refactor/change-react-promise-status-type
branch
from
0847985 to
bde002b
Compare
ifabriciorodrigues
force-pushed
the
refactor/change-react-promise-status-type
branch
from
bde002b to
fc5dcd6
Compare
ifabriciorodrigues
force-pushed
the
refactor/change-react-promise-status-type
branch
from
fc5dcd6 to
4c57b79
Compare
ifabriciorodrigues
force-pushed
the
refactor/change-react-promise-status-type
branch
from
4c57b79 to
0d2be62
Compare
ifabriciorodrigues
force-pushed
the
refactor/change-react-promise-status-type
branch
from
0d2be62 to
d77e663
Compare
ifabriciorodrigues
force-pushed
the
refactor/change-react-promise-status-type
branch
from
d77e663 to
c278617
Compare
ifabriciorodrigues
force-pushed
the
refactor/change-react-promise-status-type
branch
from
c278617 to
3e74f71
Compare
ifabriciorodrigues
force-pushed
the
refactor/change-react-promise-status-type
branch
from
3e74f71 to
b2d641d
Compare
ifabriciorodrigues
force-pushed
the
refactor/change-react-promise-status-type
branch
from
b2d641d to
5df7c59
Compare
ifabriciorodrigues
force-pushed
the
refactor/change-react-promise-status-type
branch
from
5df7c59 to
ace114a
Compare
ifabriciorodrigues
force-pushed
the
refactor/change-react-promise-status-type
branch
from
ace114a to
7c88343
Compare
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
github-actions
bot
added
the
Resolution: Stale
|
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #31467
Summary
This PR standardizes the use of predefined types for the ReactPromise function's status field. Currently, it accepts any type for the status field, which reduces code readability and prevents proper autocompletion.
How did you test this change?
I ran the tests using yarn test and yarn test --prod. Since this is a type change, all relevant usage scenarios were already covered during development and testing.