-
Notifications
You must be signed in to change notification settings - Fork 7.6k
feat(SDFS): Add destructor for SD card to clean up resources #11521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Hello JakubAndrysek, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 76 files 76 suites 13m 59s ⏱️ Results for commit 7fabe3b. ♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Description of Change
This pull request introduces a destructor to the
SDFS
class in the SD library to ensure proper cleanup when an instance of the class is destroyed. The destructor calls theend()
method to release resources.Tests scenarios
I have tested my Pull Request on Arduino-esp32 core v3.2.0 with Wokwi and on ESP32 S3 with two connected SD cards.
Tests of the whole SD library will be included in the next PR (separated from this one).
unique_ptr
.