chore: update TypeScript to v6 by sethamus · Pull Request #740 · eslint/js

sethamus · 2026-03-26T02:19:46Z

Prerequisites checklist

I have read the contributing guidelines.

AI acknowledgment

I did not use AI to generate this PR.
(If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request?

This PR updates the repo’s TypeScript tooling to v6.

What changes did you make? (Give an overview)

bump typescript to v6 in package.json.
updated the TypeScript module settings to use moduleResolution: "nodenext" and module: "nodenext" instead of the deprecated moduleResolution: "node" setup.
added rootDir: "lib" to eslint-visitor-keys.

Related Issues

Is there anything you'd like reviewers to focus on?

nzakas · 2026-03-26T20:33:36Z

Please hold off. There's already a bunch of "Update TypeScript to v6" PRs across the org and we're not even sure we want to upgrade immediately.

sethamus · 2026-03-27T16:49:07Z

@nzakas Sorry for the PRs! I opened these based on the discussion in my other PR (eslint/eslint#20547 (comment)), which suggested that once TypeScript 6 is officially released, we should update our tooling.

github-actions · 2026-04-06T22:43:24Z

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

github-actions · 2026-04-20T22:44:35Z

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

nzakas · 2026-04-24T13:34:28Z

Gotcha. @fasttime I'll leave it up to you to review.

lumirlumir

Just a note that there are currently some CI failures related to this update.

fasttime · 2026-04-30T06:59:06Z

The type tests are still failing.

fasttime · 2026-05-16T19:48:53Z

Are the types wrong? CI job is now failing with attw --pack crashing on Cannot read properties of undefined (reading 'filename'). This seems related to arethetypeswrong/arethetypeswrong.github.io#258, and may require the same temporary workaround used in eslint/eslint#20877 or eslint/rewrite#458.

fasttime · 2026-05-16T20:36:50Z

To clear the CI failure: #751.

fasttime

LGTM, thanks! Leaving open for @lumirlumir to review the changes.

lumirlumir · 2026-06-04T05:26:43Z

I’m sorry for the delay. I need some dedicated time to review this PR, and I’ll make sure to review it by the end of this weekend.

lumirlumir

LGTM, thanks for your patience and hard work on this PR.

Would like @fasttime to verify the changes before merging.

lumirlumir

Re-approving.

fasttime

LGTM, thanks!

chore: update TypeScript to v6

af2c14e

github-project-automation Bot added this to Triage Mar 26, 2026

github-project-automation Bot moved this to Needs Triage in Triage Mar 26, 2026

eslint-github-bot Bot added the chore label Mar 26, 2026

github-actions Bot added Stale and removed Stale labels Apr 6, 2026

lumirlumir moved this from Needs Triage to Implementing in Triage Apr 18, 2026

github-actions Bot added the Stale label Apr 20, 2026

sethamus added 3 commits April 22, 2026 17:37

Merge branch 'main' into update-typescript-to-v6

58beda1

update deps

33f8b14

update tsconfigs for TypeScript 6

703a3a1

sethamus marked this pull request as ready for review April 22, 2026 15:23

github-actions Bot removed the Stale label Apr 22, 2026

lumirlumir requested changes Apr 25, 2026

View reviewed changes

Comment thread package.json

lumirlumir added the accepted label Apr 25, 2026

sethamus added 2 commits April 27, 2026 00:00

fix ci

d1c4438

add type tests to CI workflow

0e83e1d

fix ci

2a28703

fasttime added the contributor pool label May 12, 2026

fasttime reviewed May 12, 2026

View reviewed changes

Comment thread tsconfig.base.json

Comment thread packages/eslint-scope/tests/types/tsconfig.json

sethamus added 3 commits May 13, 2026 12:23

apply suggestions and fix ci

e878949

Merge branch 'main' into update-typescript-to-v6

58a6e64

run type tests with TypeScript 7

ffd5ede

lumirlumir requested changes May 13, 2026

View reviewed changes

Comment thread packages/eslint-scope/tests/types/cjs-import.test.cts

Comment thread packages/eslint-visitor-keys/test-d/index.test-d.ts Outdated

apply suggestion

dc1934b

sethamus added 3 commits May 17, 2026 06:47

Merge branch 'main' into update-typescript-to-v6

4cb0f5a

apply suggestion

3cca92d

Merge branch 'main' into update-typescript-to-v6

ae8dde9

fasttime previously approved these changes May 28, 2026

View reviewed changes

fasttime moved this from Implementing to Second Review Needed in Triage May 28, 2026

lumirlumir requested changes Jun 7, 2026

View reviewed changes

Comment thread tsconfig.base.json Outdated

Comment thread tsconfig.base.json Outdated

Comment thread tsconfig.base.json

Comment thread packages/eslint-visitor-keys/tsconfig.json

Comment thread packages/espree/rollup.config.js

apply suggestions

a9d6acb

sethamus dismissed fasttime’s stale review via a9d6acb June 7, 2026 23:26

lumirlumir requested changes Jun 14, 2026

View reviewed changes

Comment thread package.json

Comment thread packages/eslint-scope/tsconfig.json Outdated

Comment thread packages/eslint-scope/tests/types/tsconfig.json Outdated

Comment thread .github/workflows/ci.yml

apply suggestions

b39d192

sethamus requested a review from a team as a code owner June 15, 2026 23:35

lumirlumir previously approved these changes Jun 19, 2026

View reviewed changes

lumirlumir requested a review from fasttime June 19, 2026 10:32

fasttime reviewed Jun 20, 2026

View reviewed changes

Comment thread packages/eslint-scope/tests/types/tsconfig.json Outdated

Comment thread tsconfig.dist-legacy.json Outdated

Comment thread tsconfig.dist.json Outdated

remove redundant settings

ad45ab1

sethamus dismissed lumirlumir’s stale review via ad45ab1 July 1, 2026 13:41

lumirlumir approved these changes Jul 2, 2026

View reviewed changes

lumirlumir requested a review from fasttime July 2, 2026 04:28

fasttime approved these changes Jul 2, 2026

View reviewed changes

fasttime merged commit 922e7ee into eslint:main Jul 2, 2026
20 checks passed

github-project-automation Bot moved this from Second Review Needed to Complete in Triage Jul 2, 2026

Uh oh!

Uh oh!

Conversation

sethamus commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Prerequisites checklist

AI acknowledgment

What is the purpose of this pull request?

What changes did you make? (Give an overview)

Related Issues

Is there anything you'd like reviewers to focus on?

nzakas commented Mar 26, 2026

sethamus commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

github-actions Bot commented Apr 6, 2026

github-actions Bot commented Apr 20, 2026

nzakas commented Apr 24, 2026

lumirlumir left a comment

Choose a reason for hiding this comment

Uh oh!

fasttime commented Apr 30, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fasttime commented May 16, 2026

fasttime commented May 16, 2026

fasttime left a comment

Choose a reason for hiding this comment

lumirlumir commented Jun 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lumirlumir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lumirlumir left a comment

Choose a reason for hiding this comment

fasttime left a comment

Choose a reason for hiding this comment

Uh oh!

Labels

4 participants

sethamus commented Mar 26, 2026 •

edited

Loading

sethamus commented Mar 27, 2026 •

edited

Loading