Skip to content

[SLO]: Include spaceID in SLI documents #214278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 13, 2025

Conversation

baileycash-elastic
Copy link
Contributor

@baileycash-elastic baileycash-elastic commented Mar 12, 2025

Summary

Resolves #213464

Release Notes

SpaceId can now be referenced in document-based access filters for roles to restrict a user's access to SLI data for spaces where they do not have access.

@baileycash-elastic baileycash-elastic added backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) Team:obs-ux-management Observability Management User Experience Team release_note:enhancement labels Mar 12, 2025
@baileycash-elastic baileycash-elastic marked this pull request as ready for review March 12, 2025 21:01
@baileycash-elastic baileycash-elastic requested a review from a team as a code owner March 12, 2025 21:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@baileycash-elastic baileycash-elastic changed the title Slo 213464 chore/slo: Include spaceID in SLI documents Mar 12, 2025
@baileycash-elastic baileycash-elastic changed the title chore/slo: Include spaceID in SLI documents [SLO]: Include spaceID in SLI documents Mar 12, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 12, 2025

💔 Build Failed

Failed CI Steps

History

Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baileycash-elastic baileycash-elastic enabled auto-merge (squash) March 13, 2025 18:08
@baileycash-elastic baileycash-elastic merged commit 22e64dc into elastic:main Mar 13, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.0

https://github.com/elastic/kibana/actions/runs/13842202920

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 13, 2025
## Summary

Resolves elastic#213464

## Release Notes

SpaceId can now be referenced in document-based access filters for roles
to restrict a user's access to SLI data for spaces where they do not
have access.

(cherry picked from commit 22e64dc)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 13, 2025
# Backport

This will backport the following commits from `main` to `9.0`:
- [[SLO]: Include spaceID in SLI documents
(#214278)](#214278)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Bailey
Cash","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-03-13T18:39:38Z","message":"[SLO]:
Include spaceID in SLI documents (#214278)\n\n## Summary\n\nResolves
#213464 \n\n## Release Notes\n\nSpaceId can now be referenced in
document-based access filters for roles\nto restrict a user's access to
SLI data for spaces where they do not\nhave
access.","sha":"22e64dc868c96dc3d00b0b4270c97dc57e0146a3","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","backport:prev-minor","Team:obs-ux-management","v9.1.0"],"title":"[SLO]:
Include spaceID in SLI documents
","number":214278,"url":"https://github.com/elastic/kibana/pull/214278","mergeCommit":{"message":"[SLO]:
Include spaceID in SLI documents (#214278)\n\n## Summary\n\nResolves
#213464 \n\n## Release Notes\n\nSpaceId can now be referenced in
document-based access filters for roles\nto restrict a user's access to
SLI data for spaces where they do not\nhave
access.","sha":"22e64dc868c96dc3d00b0b4270c97dc57e0146a3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/214278","number":214278,"mergeCommit":{"message":"[SLO]:
Include spaceID in SLI documents (#214278)\n\n## Summary\n\nResolves
#213464 \n\n## Release Notes\n\nSpaceId can now be referenced in
document-based access filters for roles\nto restrict a user's access to
SLI data for spaces where they do not\nhave
access.","sha":"22e64dc868c96dc3d00b0b4270c97dc57e0146a3"}}]}]
BACKPORT-->

Co-authored-by: Bailey Cash <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Mar 22, 2025
## Summary

Resolves elastic#213464 

## Release Notes

SpaceId can now be referenced in document-based access filters for roles
to restrict a user's access to SLI data for spaces where they do not
have access.
@baileycash-elastic
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

baileycash-elastic added a commit to baileycash-elastic/kibana that referenced this pull request May 6, 2025
## Summary

Resolves elastic#213464

## Release Notes

SpaceId can now be referenced in document-based access filters for roles
to restrict a user's access to SLI data for spaces where they do not
have access.

(cherry picked from commit 22e64dc)

# Conflicts:
#	x-pack/solutions/observability/plugins/slo/server/assets/ingest_templates/sli_pipeline_template.ts
baileycash-elastic added a commit that referenced this pull request May 7, 2025
# Backport

This will backport the following commits from `main` to `8.19`:
- [[SLO]: Include spaceID in SLI documents
(#214278)](#214278)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Bailey
Cash","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-03-13T18:39:38Z","message":"[SLO]:
Include spaceID in SLI documents (#214278)\n\n## Summary\n\nResolves
#213464 \n\n## Release Notes\n\nSpaceId can now be referenced in
document-based access filters for roles\nto restrict a user's access to
SLI data for spaces where they do not\nhave
access.","sha":"22e64dc868c96dc3d00b0b4270c97dc57e0146a3","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","v9.0.0","backport:prev-minor","Team:obs-ux-management","v9.1.0"],"title":"[SLO]:
Include spaceID in SLI documents
","number":214278,"url":"https://github.com/elastic/kibana/pull/214278","mergeCommit":{"message":"[SLO]:
Include spaceID in SLI documents (#214278)\n\n## Summary\n\nResolves
#213464 \n\n## Release Notes\n\nSpaceId can now be referenced in
document-based access filters for roles\nto restrict a user's access to
SLI data for spaces where they do not\nhave
access.","sha":"22e64dc868c96dc3d00b0b4270c97dc57e0146a3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/214466","number":214466,"state":"MERGED","mergeCommit":{"sha":"0afeee0c9873192de0e703f328493d7fabe1c2e3","message":"[9.0]
[SLO]: Include spaceID in SLI documents (#214278) (#214466)\n\n#
Backport\n\nThis will backport the following commits from `main` to
`9.0`:\n- [[SLO]: Include spaceID in SLI
documents\n(#214278)](https://github.com/elastic/kibana/pull/214278)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Bailey Cash
<[email protected]>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/214278","number":214278,"mergeCommit":{"message":"[SLO]:
Include spaceID in SLI documents (#214278)\n\n## Summary\n\nResolves
#213464 \n\n## Release Notes\n\nSpaceId can now be referenced in
document-based access filters for roles\nto restrict a user's access to
SLI data for spaces where they do not\nhave
access.","sha":"22e64dc868c96dc3d00b0b4270c97dc57e0146a3"}}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:enhancement Team:obs-ux-management Observability Management User Experience Team v8.19.0 v9.0.0 v9.1.0
4 participants