Skip to content

Conversation

@agithomas
Copy link
Contributor

@agithomas agithomas commented Nov 30, 2024

Proposed commit message

Add connection log support for AWS ELB

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • Integration testing

How to test this PR locally

  • elastic-package build
  • elastic-package stack up -v -d --services package-registry
  • elastic-package test pipeline -d elb_logs

Related issues

Screenshots

image
@andrewkroh andrewkroh added enhancement New feature or request Integration:aws AWS labels Nov 30, 2024
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Nov 30, 2024

🚀 Benchmarks report

Package aws 👍(10) 💚(3) 💔(6)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
guardduty 948.77 776.4 -172.37 (-18.17%) 💔
inspector 1937.98 1512.86 -425.12 (-21.94%) 💔
rds 19607.84 14285.71 -5322.13 (-27.14%) 💔
s3access 4132.23 2906.98 -1225.25 (-29.65%) 💔
securityhub_insights 921.66 593.82 -327.84 (-35.57%) 💔
emr_logs 13698.63 9615.38 -4083.25 (-29.81%) 💔

To see the full report comment with /test benchmark fullreport

@agithomas agithomas marked this pull request as ready for review December 4, 2024 07:13
@agithomas agithomas requested review from a team as code owners December 4, 2024 07:13
@andrewkroh andrewkroh added the Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Dec 4, 2024
@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💚 Build #19012 succeeded 0f23a4a4b515037f9d869ac6471cef0c37c03d05
  • 💔 Build #19010 failed 7422180d2f6779a8767567d93a6f41acacc47e23
  • 💚 Build #18915 succeeded 11bcafc2261dd696b5c8da68858cbccad3dcedca
  • 💔 Build #18913 failed 7d6104682bdcbda43f980b50aa50b5135690dc8b
  • 💔 Build #18911 failed d2501ab75df99933b794b95fc6333f5bfac50d49
Copy link
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@agithomas agithomas merged commit 49c7ed1 into elastic:main Dec 4, 2024
5 checks passed
@elastic-vault-github-plugin-prod

Package aws - 2.35.0 containing this change is available at https://epr.elastic.co/package/aws/2.35.0/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@agithomas agithomas deleted the issue-11770 branch February 6, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:aws AWS Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

5 participants