The filter and significant_terms aggregations should parse the filter as a filter, not a query.
#23797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we have a test? :) |
|
Yes sorry, it definitely needs one but I had not decided yet what would be best between stopping to parse queries and filters differently and keeping that functionnality. I was leaning towards the first option given that the |
|
@jpountz same thing needs to be done here as well SignificantTermsAggregatorFactory#filter? |
|
@rahul1193 you are correct! |
c0b6e86 to
fb44a67
Compare
filter aggregation should parse the filter as a filter, not a query.filter and significant_terms aggregations should parse the filter as a filter, not a query.
|
OK, I fixed |
…ilter` as a filter, not as a query. This is important for some queries like `bool`, which are parsed differently depending on whether we want to get a query or a filter.
fb44a67 to
37dab2f
Compare
rahulanishetty
pushed a commit
to rahulanishetty/elasticsearch
that referenced
this pull request
Apr 13, 2017
…ilter` as a filter, not as a query. (elastic#23797) This is important for some queries like `bool`, which are parsed differently depending on whether we want to get a query or a filter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is important for some queries like
terms, which are parsed differentlydepending on whether we want to get a query or a filter.