Make Engine.awaitPendingClose protected #130004
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that the method can be used by classes implementing the Engine abstract class.
tlrx
added
>non-issue
:Distributed Indexing/Engine
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
elasticsearchmachine
added
Team:Distributed Indexing
fcofdez
reviewed
Jun 25, 2025
| @@ -2199,7 +2199,7 @@ public void close() throws IOException { | |||
| awaitPendingClose(); | |||
| } | |||
|
|
|||
| private void awaitPendingClose() { | |||
| protected final void awaitPendingClose() { | |||
There was a problem hiding this comment.
aren't we getting the closedLatch in the closeNoLock method parameter?
There was a problem hiding this comment.
Maybe it's helpful to describe how you're planning to use this method in the inheritors
There was a problem hiding this comment.
aren't we getting the closedLatch in the
closeNoLockmethod parameter?
Yes, but that one is final in InternalEngine
Maybe it's helpful to describe how you're planning to use this method in the inheritors
Exposing the method as package-protected in implementations, allowing its usage in tests.
There was a problem hiding this comment.
See the linked pull request for such an usage.
fcofdez
approved these changes
Jun 25, 2025
kingherc
approved these changes
Jun 25, 2025
tlrx
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that the method can be used by classes implementing the Engine abstract class.