-
Notifications
You must be signed in to change notification settings - Fork 25.4k
Pushdown for LIKE (LIST) #129557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
julian-elastic
merged 12 commits into
elastic:main
from
julian-elastic:likeListPushdown_v3
Jun 23, 2025
Merged
Pushdown for LIKE (LIST) #129557
julian-elastic
merged 12 commits into
elastic:main
from
julian-elastic:likeListPushdown_v3
Jun 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik9000
reviewed
Jun 17, 2025
server/src/main/java/org/elasticsearch/index/query/AutomatonQueryBuilder.java
Outdated
Show resolved
Hide resolved
...le-node/src/javaRestTest/java/org/elasticsearch/xpack/esql/qa/single_node/PushQueriesIT.java
Outdated
Show resolved
Hide resolved
Hi @julian-elastic, I've created a changelog YAML for you. |
Pinging @elastic/es-analytical-engine (Team:Analytics) |
nik9000
reviewed
Jun 20, 2025
server/src/main/java/org/elasticsearch/index/query/AutomatonQueryBuilder.java
Outdated
Show resolved
Hide resolved
...a/org/elasticsearch/xpack/esql/expression/function/scalar/string/regex/WildcardLikeList.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/query/AutomatonQueryBuilder.java
Outdated
Show resolved
Hide resolved
nik9000
approved these changes
Jun 23, 2025
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
julian-elastic
added a commit
to julian-elastic/elasticsearch
that referenced
this pull request
Jun 23, 2025
Improved performance of LIKE (LIST) by pushing an Automaton to do the evaluation down to Lucine. (cherry picked from commit caae426) # Conflicts: # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/string/regex/WildcardLikeList.java
julian-elastic
added a commit
that referenced
this pull request
Jun 23, 2025
Improved performance of LIKE (LIST) by pushing an Automaton to do the evaluation down to Lucine. (cherry picked from commit caae426) # Conflicts: # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/string/regex/WildcardLikeList.java
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 25, 2025
Improved performance of LIKE (LIST) by pushing an Automaton to do the evaluation down to Lucine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Analytics/ES|QL
AKA ESQL
auto-backport
Automatically create backport pull requests when merged
backport pending
>enhancement
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
v8.19.0
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved performance of LIKE (LIST) by a factor of 5 by pushing an Automaton to do the evaluation down to Lucine
Measured by this script, look at
test like list
with and without this change