Skip to content

[build] Sign '*.node' files for MacOS#1404

Merged
vrubezhny merged 1 commit into
eclipse-wildwebdeveloper:masterfrom
vrubezhny:fix-add-node-modules-signing-for-macos
Nov 20, 2023
Merged

[build] Sign '*.node' files for MacOS#1404
vrubezhny merged 1 commit into
eclipse-wildwebdeveloper:masterfrom
vrubezhny:fix-add-node-modules-signing-for-macos

Conversation

@vrubezhny
Copy link
Copy Markdown
Contributor

This PR has the goal to resolve issue #1403 by implementing the steps that are performed in Orbit to sign Mac '*.node' NPM modules for the WWD build.

@vrubezhny vrubezhny marked this pull request as draft November 17, 2023 17:41
@vrubezhny vrubezhny force-pushed the fix-add-node-modules-signing-for-macos branch 4 times, most recently from 1daad70 to 9cda709 Compare November 18, 2023 00:12
@vrubezhny vrubezhny changed the title [build] Sign '*.node' files [build] Sign '*.node' files for MacOS Nov 18, 2023
@vrubezhny vrubezhny force-pushed the fix-add-node-modules-signing-for-macos branch from 9cda709 to 1927192 Compare November 18, 2023 00:46
@vrubezhny
Copy link
Copy Markdown
Contributor Author

vrubezhny commented Nov 20, 2023

Mac signing breaks the WWD Jarsigner's signature as it changes and re-packs the already signed jar

image

@vrubezhny vrubezhny force-pushed the fix-add-node-modules-signing-for-macos branch from 1927192 to 5cd06df Compare November 20, 2023 13:50
@vrubezhny
Copy link
Copy Markdown
Contributor Author

This time o.e.wwd plugin's jar appears to be correctly signed, however there is still some unsigned contents:
image

However I'm not sure if this is to be solved in WWD

@vrubezhny
Copy link
Copy Markdown
Contributor Author

@jonahgraham Can you try building an EPP using the following PR's updated site: https://ci.eclipse.org/wildwebdeveloper/job/Wildwebdeveloper/job/PR-1404/6/artifact/repository/target/repository/ (or any later one if exists by the time)?

@mickaelistria
Copy link
Copy Markdown
Contributor

This time o.e.wwd plugin's jar appears to be correctly signed, however there is still some unsigned contents:

Those are supposed to be signed by PGP, after the "assemble-repository" step.

@vrubezhny
Copy link
Copy Markdown
Contributor Author

This time o.e.wwd plugin's jar appears to be correctly signed, however there is still some unsigned contents:

Those are supposed to be signed by PGP, after the "assemble-repository" step.

Then I expects we're OK with this (Just need to polish pom and remove not needed profile call added to Jenkinsfile)

This PR has the goal to resolve issue eclipse-wildwebdeveloper#1403 by implementing the steps
that are performed in Orbit to sign Mac '*.node' NPM modules for the
WWD build.

Fixes: eclipse-wildwebdeveloper#1403
@vrubezhny vrubezhny force-pushed the fix-add-node-modules-signing-for-macos branch from 5cd06df to 113b059 Compare November 20, 2023 15:42
@vrubezhny vrubezhny marked this pull request as ready for review November 20, 2023 16:26
@vrubezhny vrubezhny linked an issue Nov 20, 2023 that may be closed by this pull request
@vrubezhny vrubezhny merged commit a2413c3 into eclipse-wildwebdeveloper:master Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants