Skip to content

Add pixel definitions for contingency and browser menu#9097

Open
CrisBarreiro wants to merge 1 commit into
developfrom
feature/cris/ad-blocking-pixel-triage
Open

Add pixel definitions for contingency and browser menu#9097
CrisBarreiro wants to merge 1 commit into
developfrom
feature/cris/ad-blocking-pixel-triage

Conversation

@CrisBarreiro

@CrisBarreiro CrisBarreiro commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Task/Issue URL:
Tech Design URL (if applicable): https://app.asana.com/1/137249556945/project/1212227266948491/task/1216264344628719?focus=true

Description

Steps to test this PR

Feature 1

  • [ ]
  • [ ]

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

Note

Low Risk
Telemetry schema and enum additions only; no runtime behavior, auth, or ad-blocking logic changes in this PR.

Overview
Adds 12 new YouTube ad blocking pixels (daily + count pairs) so product can measure browsing-menu enable/disable flows, disable-mode picker choices, and breakage reporting after a menu-driven disable.

ad_blocking.json5 registers events for: re-enable from the menu, opening the disable picker, picker options Always On, Always Off, and Disable Until Relaunch, plus Report Broken Site on the post-disable prompt. AdBlockingPixelNames mirrors each name with matching enum constants for app code to fire later.

This diff is definitions only—no new pixel firing or UI logic in the changed files.

Reviewed by Cursor Bugbot for commit 028536e. Bugbot is set up for automated code reviews on this repo. Configure here.

@CrisBarreiro CrisBarreiro mentioned this pull request Jul 3, 2026
10 tasks

CrisBarreiro commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator Author
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/ad-blocking-pixel-triage branch 2 times, most recently from b3e8f2f to ab35ae1 Compare July 7, 2026 10:47
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/enable-contingency-messaging branch 2 times, most recently from 60e63f7 to abec109 Compare July 7, 2026 10:57
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/ad-blocking-pixel-triage branch 2 times, most recently from bd789f7 to 1440703 Compare July 7, 2026 11:10
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/enable-contingency-messaging branch from 183d4bf to 9bf11e2 Compare July 8, 2026 08:32
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/ad-blocking-pixel-triage branch from 1440703 to b8deabe Compare July 8, 2026 08:32
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/enable-contingency-messaging branch 2 times, most recently from cfb68de to 1af6633 Compare July 8, 2026 08:55
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/ad-blocking-pixel-triage branch from b8deabe to 57a630b Compare July 8, 2026 08:55
@CrisBarreiro CrisBarreiro changed the base branch from feature/cris/enable-contingency-messaging to graphite-base/9097 July 8, 2026 14:35
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/ad-blocking-pixel-triage branch from 57a630b to d642733 Compare July 9, 2026 10:10
@CrisBarreiro CrisBarreiro changed the base branch from graphite-base/9097 to feature/cris/enable-contingency-messaging July 9, 2026 10:10
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/ad-blocking-pixel-triage branch 2 times, most recently from f081fcb to 4548d6a Compare July 9, 2026 10:25
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/enable-contingency-messaging branch from fd2e2b1 to 84e11a7 Compare July 9, 2026 10:25
@CrisBarreiro CrisBarreiro changed the base branch from feature/cris/enable-contingency-messaging to graphite-base/9097 July 9, 2026 10:56
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/ad-blocking-pixel-triage branch from 4548d6a to 4eb08a8 Compare July 9, 2026 10:57
@CrisBarreiro CrisBarreiro changed the base branch from graphite-base/9097 to feature/cris/extract-domain-matcher July 9, 2026 10:57
@CrisBarreiro CrisBarreiro changed the base branch from feature/cris/extract-domain-matcher to graphite-base/9097 July 9, 2026 12:34
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/ad-blocking-pixel-triage branch from 4eb08a8 to a89b503 Compare July 9, 2026 12:35
@graphite-app graphite-app Bot changed the base branch from graphite-base/9097 to develop July 9, 2026 12:35
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/ad-blocking-pixel-triage branch from a89b503 to 028536e Compare July 9, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

1 participant