Skip to content

Make NegotiateAuthentication.[Compute/Verify]IntegrityCheck APIs public #96712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 10, 2024

Conversation

filipnavara
Copy link
Member

@filipnavara filipnavara commented Jan 9, 2024

Fixes #86950

@ghost ghost added area-System.Net.Security community-contribution Indicates that the PR has been added by a community member labels Jan 9, 2024
@ghost
Copy link

ghost commented Jan 9, 2024

Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

TODO: Add tests!

Fixes #86950

Author: filipnavara
Assignees: -
Labels:

area-System.Net.Security

Milestone: -
@filipnavara filipnavara changed the title Make NegotiateAuthentication.ComputeIntegrityCheck/VerifyIntegrityCheck APIs public Make NegotiateAuthentication.[Compute/Verify]IntegrityCheck APIs public Jan 9, 2024
@filipnavara filipnavara marked this pull request as ready for review January 9, 2024 20:24
@rzikm
Copy link
Member

rzikm commented Jan 9, 2024

That was fast :)

rzikm
rzikm previously approved these changes Jan 9, 2024
Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes

@rzikm rzikm dismissed their stale review January 9, 2024 20:39

Changes needed

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wfurt wfurt merged commit 07fbf07 into dotnet:main Jan 10, 2024
@filipnavara
Copy link
Member Author

Thanks for review!

@filipnavara filipnavara deleted the neg-integrity-check branch January 10, 2024 21:11
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
…ic (dotnet#96712)

* Make NegotiateAuthentication.ComputeIntegrityCheck/VerifyIntegrityCheck APIs public

* Update ref source

* Update usage of the internal APIs

* Add unit test

* Add exception documentation

* Fix Windows implementation of GetMIC

* Update src/libraries/System.Net.Security/src/System/Net/Security/NegotiateAuthentication.cs

Co-authored-by: Adeel Mujahid <[email protected]>

---------

Co-authored-by: Adeel Mujahid <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2024
@karelz karelz added this to the 9.0.0 milestone May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Security community-contribution Indicates that the PR has been added by a community member
6 participants