-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Make NegotiateAuthentication.[Compute/Verify]IntegrityCheck APIs public #96712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones Issue DetailsTODO: Add tests! Fixes #86950
|
That was fast :) |
src/libraries/System.Net.Security/src/System/Net/Security/NegotiateAuthentication.cs
Show resolved
Hide resolved
src/libraries/System.Net.Security/src/System/Net/Security/NegotiateAuthentication.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI passes
src/libraries/System.Net.Security/src/System/Net/Security/NegotiateAuthentication.cs
Outdated
Show resolved
Hide resolved
…tiateAuthentication.cs Co-authored-by: Adeel Mujahid <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for review! |
…ic (dotnet#96712) * Make NegotiateAuthentication.ComputeIntegrityCheck/VerifyIntegrityCheck APIs public * Update ref source * Update usage of the internal APIs * Add unit test * Add exception documentation * Fix Windows implementation of GetMIC * Update src/libraries/System.Net.Security/src/System/Net/Security/NegotiateAuthentication.cs Co-authored-by: Adeel Mujahid <[email protected]> --------- Co-authored-by: Adeel Mujahid <[email protected]>
Fixes #86950