-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Obsolete AuthenticationManager
of System.Net.Requests
#93171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Update SYSLIB0009 diagnostic * Add ObsoleteAttribute at class-level for AuthenticationManager * Use generated ref source
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #77459. This PR obsoletes the class Changed API Schemenamespace System.Net;
+ [System.ObsoleteAttribute(
+ "AuthenticationManager is not supported. Methods will no-op or throw PlatformNotSupportedException.",
+ DiagnosticId = "SYSLIB0009",
+ UrlFormat = "https://aka.ms/dotnet-warnings/{0}")]
public partial class AuthenticationManager
{
// ...
} Changes made
/cc @MihaZupan
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
It seems like test failures are relevant. We will need to work out suppression as the change is intended. |
Fixes #77459. This PR obsoletes the class
AuthenticationManager
.Changed API Scheme
Changes made
SYSLIB0009
SYSLIB0009
obsoletion at class-level (AuthenticationManager
)/cc @MihaZupan