Skip to content

Obsolete AuthenticationManager of System.Net.Requests #93171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 10, 2023

Conversation

deeprobin
Copy link
Contributor

Fixes #77459. This PR obsoletes the class AuthenticationManager.

Changed API Scheme

namespace System.Net;

+ [System.ObsoleteAttribute(
+   "AuthenticationManager is not supported. Methods will no-op or throw PlatformNotSupportedException.",
+    DiagnosticId = "SYSLIB0009",
+    UrlFormat = "https://aka.ms/dotnet-warnings/{0}")]
public partial class AuthenticationManager
{
    // ...
}

Changes made

  • Change message of existing diagnostic SYSLIB0009
  • Apply SYSLIB0009 obsoletion at class-level (AuthenticationManager)
  • Disable diagnostic in AuthenticationManager tests
  • Update runtime docs

/cc @MihaZupan

* Update SYSLIB0009 diagnostic
* Add ObsoleteAttribute at class-level for AuthenticationManager
* Use generated ref source
@ghost
Copy link

ghost commented Oct 7, 2023

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 7, 2023
@ghost
Copy link

ghost commented Oct 7, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #77459. This PR obsoletes the class AuthenticationManager.

Changed API Scheme

namespace System.Net;

+ [System.ObsoleteAttribute(
+   "AuthenticationManager is not supported. Methods will no-op or throw PlatformNotSupportedException.",
+    DiagnosticId = "SYSLIB0009",
+    UrlFormat = "https://aka.ms/dotnet-warnings/{0}")]
public partial class AuthenticationManager
{
    // ...
}

Changes made

  • Change message of existing diagnostic SYSLIB0009
  • Apply SYSLIB0009 obsoletion at class-level (AuthenticationManager)
  • Disable diagnostic in AuthenticationManager tests
  • Update runtime docs

/cc @MihaZupan

Author: deeprobin
Assignees: -
Labels:

area-System.Net, new-api-needs-documentation

Milestone: -
Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rzikm rzikm requested a review from MihaZupan October 9, 2023 07:13
Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@MihaZupan MihaZupan added this to the 9.0.0 milestone Oct 9, 2023
@wfurt
Copy link
Member

wfurt commented Oct 9, 2023

It seems like test failures are relevant. We will need to work out suppression as the change is intended.

@MihaZupan MihaZupan merged commit 5b7ab04 into dotnet:main Oct 10, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
4 participants