Add DependencyKind.DisablePrivateReflectionRequirement to methodreasons and typereasons to fix tests.#128461
Open
jtschuster wants to merge 1 commit into
Open
Add DependencyKind.DisablePrivateReflectionRequirement to methodreasons and typereasons to fix tests.#128461jtschuster wants to merge 1 commit into
jtschuster wants to merge 1 commit into
Conversation
…ns and typereasons to fix tests
dotnet-policy-service
Bot
added
the
linkable-framework
github-actions
Bot
added
the
area-Tools-ILLink
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/illink |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates ILLink’s MarkStep debug-only validation allowlists to recognize DependencyKind.DisablePrivateReflectionRequirement as a valid reason when marking types and methods. This prevents DEBUG builds/tests from throwing due to the newly used dependency kind when the linker roots DisablePrivateReflectionAttribute.
Changes:
- Add
DependencyKind.DisablePrivateReflectionRequirementto the_typeReasonsallowlist used byMarkTypeDEBUG validation. - Add
DependencyKind.DisablePrivateReflectionRequirementto the_methodReasonsallowlist used byProcessMethodDEBUG validation.
sbomer
approved these changes
May 21, 2026
Member
Author
|
RequiresUnsafe failure seems like something for a separate PR. |
Member
|
I think you can delete the RequiresUnsafe analyzer now and just keep the code fixer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#128349 started running tests with a Debug illink, which is tripping an assert. I missed the fact that the illink unit tests didn't run and now those tests are failing: #128349 (comment)
To fix, add this reason as an expected reason for marking a method or a type.