[28.x backport] cli/command: remove AddTrustSigningFlags, AddTrustVerificationFlags, AddPlatformFlag utilities
#6311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it was only used internally in a single location, so inline the code where it's used. Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 8c22927) Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
impact/deprecation
status/2-code-review
area/trust
area/go-sdk
thaJeztah
force-pushed
the
28.x_backport_deprecate_platform_flags
branch
2 times, most recently
from
6494d4b to
dc2c262
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
These were already removed in master, so adding an extra commit in the 28.x branch to remove their use. Signed-off-by: Sebastiaan van Stijn <[email protected]>
It was only used internally; inline it where used. Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit c0fbbe0) Signed-off-by: Sebastiaan van Stijn <[email protected]>
It was only used internally and has no external users. It should not be used for new uses, because it also adds a minimum API version constraint and a default from env-var, which must be evaluated for each individual use of such flags. Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 7026e68) Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
28.x_backport_deprecate_platform_flags
branch
from
dc2c262 to
8088471
Compare
1 task
Benehiko
approved these changes
Aug 20, 2025
vvoland
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddTrustSigningFlags,AddTrustVerificationFlags,AddPlatformFlagutilities #6244cli/command: remove AddTrustSigningFlags
It was only used internally in a single location, so inline the code where it's used.
cli/command: remove AddTrustVerificationFlags
It was only used internally; inline it where used.
cli/command: remove AddPlatformFlag utility
It was only used internally and has no external users. It should not be
used for new uses, because it also adds a minimum API version constraint
and a default from env-var, which must be evaluated for each individual
use of such flags.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)