[28.x backport] cli-plugins/manager: deprecate annotation metadata aliases #6298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These aliases were added in 292713c (part of v28.0), but did not deprecate them. They are no longer used in the CLI itself, but may be used by cli-plugin implementations. This deprecates the aliases in `cli-plugins/manager` in favor of their equivalent in `cli-plugins/manager/metadata`: - `CommandAnnotationPlugin` - `CommandAnnotationPluginVendor` - `CommandAnnotationPluginVersion` - `CommandAnnotationPluginInvalid` - `CommandAnnotationPluginCommandPath` Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 72f76f2) Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
impact/deprecation
status/2-code-review
area/plugins
kind/refactor
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Benehiko
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These aliases were added in 292713c (part of v28.0), but did not deprecate them. They are no longer used in the CLI itself, but may be used by cli-plugin implementations.
This deprecates the aliases in
cli-plugins/managerin favor of their equivalent incli-plugins/manager/metadata:CommandAnnotationPluginCommandAnnotationPluginVendorCommandAnnotationPluginVersionCommandAnnotationPluginInvalidCommandAnnotationPluginCommandPath(cherry picked from commit 72f76f2)
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)