image rm: add --platform option #6109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
impact/changelog
kind/feature
status/2-code-review
containerd-integration
thaJeztah
commented
May 26, 2025
| flags.BoolVarP(&opts.force, "force", "f", false, "Force removal of the image") | ||
| flags.BoolVar(&opts.noPrune, "no-prune", false, "Do not delete untagged parents") | ||
|
|
||
| // TODO(thaJeztah): create a "platforms" option for this (including validation / parsing). |
Member
Author
There was a problem hiding this comment.
Working on this as well, but we can merge those changes later.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6109 +/- ##
==========================================
- Coverage 55.04% 55.03% -0.01%
==========================================
Files 361 361
Lines 30142 30152 +10
==========================================
+ Hits 16591 16595 +4
- Misses 12594 12599 +5
- Partials 957 958 +1 🚀 New features to boost your workflow:
|
thaJeztah
force-pushed
the
image_rm_platform
branch
2 times, most recently
from
91cf9c6 to
350e90f
Compare
thaJeztah
commented
May 27, 2025
| func NewRemoveCommand(dockerCli command.Cli) *cobra.Command { | ||
| var opts removeOptions | ||
| func NewRemoveCommand(dockerCLI command.Cli) *cobra.Command { | ||
| var options removeOptions |
Member
Author
There was a problem hiding this comment.
FWIW; renamed this one in preparation of adding an options to the opts package (preventing this var from shadowing the import).
thaJeztah
force-pushed
the
image_rm_platform
branch
2 times, most recently
from
479f1d7 to
e7bba37
Compare
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
image_rm_platform
branch
from
e7bba37 to
bb0ca9f
Compare
18 tasks
Member
Author
|
FWIW (still need to write up) there may be some corner-cases to still look into for that feature; trying to remove a platform that doesn’t exist in the cache still errors, even with docker image ls --tree alpine
IMAGE ID DISK USAGE CONTENT SIZE EXTRA
alpine:latest a8560b36e8b8 37.8MB 11.2MB
├─ linux/amd64 1c4eef651f65 12.1MB 3.64MB
├─ linux/arm/v6 903bfe2ae994 0B 0B
├─ linux/arm/v7 9c2d245b3c01 0B 0B
├─ linux/arm64/v8 757d680068d7 12.8MB 3.99MB
├─ linux/386 2436f2b3b7d2 0B 0B
├─ linux/ppc64le 9ed53fd3b831 12.8MB 3.58MB
├─ linux/riscv64 1de5eb4a9a67 0B 0B
└─ linux/s390x fe0dcdd1f783 0B 0B
$ docker-linux-arm64 image rm --platform=linux/s390x --force alpine
Error response from daemon: failed to delete platform linux/s390x for image sha256:a8560b36e8b8210634f77d9f7f9efd7ffa463e380b75e2e74aff4511df3ef88c: image with reference alpine:latest was found but does not provide any platform |
Member
Author
|
I'll bring this one in; the above should not be a blocker for this (we can fix / improve). |
Member
Author
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)