service/logs: move to cli/internal/logdetails #5910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
impact/deprecation
status/2-code-review
area/go-sdk
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5910 +/- ##
==========================================
+ Coverage 59.26% 59.29% +0.02%
==========================================
Files 357 357
Lines 29771 29771
==========================================
+ Hits 17645 17653 +8
+ Misses 11153 11144 -9
- Partials 973 974 +1 🚀 New features to boost your workflow:
|
This package is only used by cli/command/service, and has no external consumers. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
move_service_logs
branch
from
0d3d0c8 to
6bd6b3e
Compare
laurazard
approved these changes
Mar 10, 2025
thaJeztah
commented
Mar 10, 2025
| "github.com/docker/cli/cli/command/completion" | ||
| "github.com/docker/cli/cli/command/idresolver" | ||
| "github.com/docker/cli/service/logs" | ||
| "github.com/docker/cli/cli/internal/logdetails" |
Member
Author
There was a problem hiding this comment.
Still wondering if we need to keep a separate top-level internal/ and cli/internal - not sure if we need to, but we can decide at some point which one makes most sense.
Member
Author
|
Thx! I'll bring this one in 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package is only used by cli/command/service, and has no external consumers.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)