metrics: measure run operations for exec operations #2316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
build-exec-command-time
branch
from
356856c to
dba6544
Compare
daghack
approved these changes
Mar 6, 2024
jedevc
reviewed
Mar 7, 2024
| } | ||
| } | ||
|
|
||
| var reExecType = regexp.MustCompile(`^\[.*] RUN `) |
Collaborator
There was a problem hiding this comment.
It feels weird to rely on regex of the progress stream for this.
This will only work with the dockerfile frontend, since not all exec ops will necessarily begin with RUN.
Collaborator
Collaborator
Author
There was a problem hiding this comment.
The general plan is to do it this way to start and then, when we have a better idea of what it looks like, modify the solve status to include a better way to track these or track them closer to their source rather than through the progress meter.
The initial version of these is only meant to work with the dockerfile frontend.
tonistiigi
approved these changes
Mar 14, 2024
This measures the duration of exec operations. It does not factor in whether the operation was cached or not so this should include the amount of time to determine whether an operation was cached. Signed-off-by: Jonathan A. Sternberg <[email protected]>
jsternberg
force-pushed
the
build-exec-command-time
branch
from
dba6544 to
9016d85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This measures the duration of exec operations. It does not factor in
whether the operation was cached or not so this should include the
amount of time to determine whether an operation was cached.