Fix AWS Authentication when mixing static creds and IAM profile #1816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpaquet
force-pushed
the
fix_session_token
branch
2 times, most recently
from
cbec030 to
75965dd
Compare
jedevc
approved these changes
May 19, 2023
bpaquet
force-pushed
the
fix_session_token
branch
from
75965dd to
2438845
Compare
crazy-max
approved these changes
May 19, 2023
bpaquet
force-pushed
the
fix_session_token
branch
2 times, most recently
from
351f52e to
c9c7709
Compare
jedevc
approved these changes
May 22, 2023
When the user supply static creds, we must not enrich them with a session token which is unrelated. Signed-off-by: Bertrand Paquet <[email protected]>
Collaborator
|
@bpaquet just pushed a fixup to resolve the linter issue ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user supply static creds, we must not enrich them with a session token which is unrelated.