(fix) #108: Missing _sent_notifications#109
Open
matiboy wants to merge 2 commits into
Open
Conversation
Define self._sent_notifications Fixes djacobs#104
Collaborator
|
@matiboy , if not using enhanced, it's meaningless to store sent_notifications since APNS will not respond error on fail-to-sent notification. |
Author
|
@jimhorng Ok makes sense. So now it's checking whether we're using enhanced before adding the results to the queue (which was causing the original error). Thanks |
Collaborator
|
@djacobs , I think this one is good enough to be merged 👍 |
Owner
|
Thanks @jimhorng - will review shortly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define self._sent_notifications even when not using enhanced. Problem is that _sent_notifications is used in send_notification_multiple since f33faf7
Fixes #108