Skip to content

Update acts_as_copy_target.rb #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2022
Merged

Update acts_as_copy_target.rb #67

merged 2 commits into from
Oct 6, 2022

Conversation

pa657
Copy link
Contributor

@pa657 pa657 commented Oct 4, 2022

Fix issue where adding a column mapping erase others column names.
@pa657
Update acts_as_copy_target.rb
ae90506 
Fix issue where adding a column mapping erase others column names.
@diogob
Copy link
Owner

diogob commented Oct 5, 2022

@pa657 thanks for the pull request, could you add a test case that fails without this change?
@pa657
Copy link
Contributor Author

pa657 commented Oct 6, 2022 •
edited
Loading

fix with test case.
@diogob diogob merged commit c2afdf4 into diogob:master Oct 6, 2022
@diogob
Copy link
Owner

diogob commented Oct 6, 2022

@pa657 thanks again, I have just released 1.6.1 with your fix
@pa657
Copy link
Contributor Author

pa657 commented Oct 10, 2022

@diogob Thanks to you for this very useful gem.
Without it, dealing with big amount of data is very painful...
Best regards
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@pa657 @diogob