support for generating es6 imports and .d.ts files #1
Conversation
example/test.d.ts
Outdated
| @@ -0,0 +1,1013 @@ | |||
| declare namespace proto.jspb.test { | |||
There was a problem hiding this comment.
We don't want namespaces in the es6 output. I think we can just remove this and unindent the contents.
There was a problem hiding this comment.
Removed. For nested messages and enums, I still use export namespace Foo { class Bar ... } to represent Foo.Bar, which as I understand it should merge with the sibling export class Foo { }.
example/test.d.ts
Outdated
| @@ -0,0 +1,1013 @@ | |||
| declare namespace proto.jspb.test { | |||
| export class Empty extends jspb.Message { | |||
| // @ts-nocheck | ||
|
|
||
| import * as jspb from 'google-protobuf'; | ||
| var goog = jspb; |
There was a problem hiding this comment.
This probably wiill need to be something like import { goog } from 'closure-library/goog.js.
But that may be fine to figure out later.
There was a problem hiding this comment.
the correct import for goog is import * as goog from 'closure-library/closure/goog';
We still need to figure out how the jspb stuff should be imported.
| jspb.Message.initialize(this, opt_data, 0, -1, null, null); | ||
| }; | ||
| goog.inherits(proto.jspb.test.MineField, jspb.Message); | ||
| if (goog.DEBUG && !COMPILED) { |
There was a problem hiding this comment.
I wonder if we want something like this for es6 output
There was a problem hiding this comment.
Let's include it, added to the class object after definition, and declare it as | undefined in the .d.ts.
| * @param {boolean|undefined} includeInstance Deprecated. Whether to include | ||
| * the JSPB instance for transitional soy proto support: | ||
| * http://goto/soy-param-migration | ||
| * @param {!proto.jspb.test.Empty} msg The msg instance to transform. |
There was a problem hiding this comment.
These types aren't right, they need to be imported
| * @private {!Array<number>} | ||
| * @const | ||
| */ | ||
| static repeatedFields_ = [2]; |
There was a problem hiding this comment.
Closure compiler doesn't support static class properties yet. I think you need this after the class:
/**
* List of repeated fields within this message type.
* @private {!Array<number>}
* @const
*/
Simple1.repeatedFields = [2];
|
|
||
| import * as jspb from 'google-protobuf'; | ||
| var goog = jspb; | ||
| var proto = {}; |
There was a problem hiding this comment.
This should go away in favor of imports (already done) and we should update all the types in the JSDoc strings to refer to the types we import.
Builds on protocolbuffers#150, adding:
libraryoption with ES6generate_dtsflag) and compatible (libraryoption set andimport_styleset toes6)Tested compilation of Derivita's omaha/base/ast.proto and inspecting the generated
omaha/base/ast_proto.jsandomaha/base/ast_proto.d.tsfiles.