Fix gows #2
Merged
Fix gows #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepu105
reviewed
Feb 5, 2022
| // add 2 second delay to every 10th request | ||
| if (count % 10) == 0 { | ||
| println("Adding delay. Count: ", count) | ||
| time.Sleep(2 * time.Second) | ||
| } | ||
| html, _ := ioutil.ReadFile("hello.html") // read html file | ||
| w.Header().Add("Connection", "keep-alive") |
There was a problem hiding this comment.
net/http set this header automatically if client sent Connection: keep-alive. So you don't need to do.
deepu105
reviewed
Feb 5, 2022
| defer r.Body.Close() | ||
| count++ | ||
| handleConnection(w, count) | ||
| handleConnection(w, atomic.AddInt32(&count, 1)) |
There was a problem hiding this comment.
ah yes, got too used to Rust these days :P
|
Thanks for this 🙏 I added a comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The third change might make gows be slowly but other languages possibly handle exception. So gows have to check the error for the fair.