Skip to content

Accept any IO object for credentials #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sabman merged 3 commits into from
Dec 31, 2021
Merged

Accept any IO object for credentials #94

sabman merged 3 commits into from
Dec 31, 2021

Conversation

@excid3
Copy link
Contributor

@excid3 excid3 commented Dec 30, 2021

This allows passing in credentials either as a file path or IO object. Useful if you're storing your credentials in ENV or Rails credentials for example.

FCM.new("test", "creds.json")
FCM.new("test", StringIO.new("example"))
FCM.new("test", Rails.application.credentials.dig(:google, :credentials))
hound[bot]
hound bot reviewed Dec 30, 2021
View reviewed changes
@sabman sabman merged commit c2285ff into decision-labs:master Dec 31, 2021
@sabman
Copy link
Member

sabman commented Dec 31, 2021

love it!
@mannodermaus mannodermaus mentioned this pull request Feb 8, 2022
Closed
bangline pushed a commit to Apps2Data-Holdings-Ltd/fcm that referenced this pull request Jun 12, 2024
@sabman @bangline
Merge pull request decision-labs#94 from excid3/cert-io-object
124bc66 
Accept any IO object for credentials
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@excid3 @sabman