fix replication bug#80
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to resolve a replication bug in the DuckDB client by updating type mappings, adjusting column name handling, and improving logging.
- Commented out or modified type mappings for UUID, BOOL_ARRAY, and BYTEA_ARRAY.
- Updated the duckdb_column_spec function to append a suffix for duplicate column names.
- Added logging statements and adjusted array cell conversion behavior.
Comments suppressed due to low confidence (2)
ext/trex/clients/duckdb.rs:122
- [nitpick] Appending the suffix directly to the column name with the provided x parameter may result in ambiguous column names. Consider using an explicit separator to improve clarity in the generated column names.
s.push_str(x);
ext/trex/clients/duckdb.rs:523
- Returning Value::Null for array types may lead to data loss if the array values are needed. Please confirm that this behavior is intended or implement proper conversion logic.
Cell::Array(a) => Value::Null, //a.into(),
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.