[Devops-1278] docker build push GHA#3
Merged
p-hoffmann merged 4 commits intoNov 24, 2024
Conversation
satish-a0
reviewed
Nov 14, 2024
| with: | ||
| push: true | ||
| platforms: "linux/amd64" | ||
| tags: ${{ vars.AZ_REGISTRY_NAME }}.azurecr.io/${{ matrix.AZ_REGISTRY_REPOSITORY }}:${{ steps.setup.outputs.DOCKER_IMG_TAG_NAME }}, ${{ vars.AZ_REGISTRY_NAME }}.azurecr.io/${{ matrix.AZ_REGISTRY_REPOSITORY }}:main |
Contributor
There was a problem hiding this comment.
Tag is develop instead of main
Contributor
There was a problem hiding this comment.
Pushing for DOCKER_IMG_TAG_NAME tag can be avoided since its a base image
Contributor
Author
There was a problem hiding this comment.
Have edited tag and removed push for DOCKER_IMG_TAG_NAME tag
satish-a0
reviewed
Nov 14, 2024
| on: | ||
| push: | ||
| branches: | ||
| - develop |
Contributor
There was a problem hiding this comment.
NIT: Could as CI for PR to detect failing builds in here/followup task
Contributor
Author
There was a problem hiding this comment.
Have added for PR in latest commit
satish-a0
approved these changes
Nov 14, 2024
added 4 commits
November 14, 2024 14:04
Signed-off-by: mwaiyee <waiyee.man@data4life-asia.care>
Signed-off-by: mwaiyee <waiyee.man@data4life-asia.care>
Signed-off-by: mwaiyee <waiyee.man@data4life-asia.care>
- Removed push for `DOCKER_IMG_TAG_NAME` to ACR - Edit tag to `develop` Signed-off-by: mwaiyee <waiyee.man@data4life-asia.care>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GHA to docker build push Dockerfile in https://github.com/alp-os/trex/blob/develop/build/Dockerfile