Skip to content

fix select int columns#115

Merged
p-hoffmann merged 4 commits into
developfrom
p-hoffmann/fixint
Aug 15, 2025
Merged

fix select int columns#115
p-hoffmann merged 4 commits into
developfrom
p-hoffmann/fixint

Conversation

@p-hoffmann

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings August 15, 2025 02:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes handling of integer columns and other data types in the Arrow-to-JSON conversion function. The change adds comprehensive support for additional Arrow data types that were previously missing, including various integer sizes, unsigned integers, binary data, date/time types, and decimal values.

  • Adds support for Int8, Int16, Int32, UInt8, UInt16, UInt32, UInt64, and Float32 data types
  • Implements binary data encoding using base64
  • Adds comprehensive date, time, and timestamp handling with proper TimeUnit matching

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

File Description
ext/trex/lib.rs Adds extensive data type handling in field_value_to_json function with proper Arrow array imports
ext/trex/Cargo.toml Adds base64 dependency for binary data encoding

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread ext/trex/lib.rs
Comment thread ext/trex/lib.rs
Comment thread ext/trex/lib.rs Outdated
@p-hoffmann p-hoffmann merged commit df0f271 into develop Aug 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants