fix select int columns#115
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes handling of integer columns and other data types in the Arrow-to-JSON conversion function. The change adds comprehensive support for additional Arrow data types that were previously missing, including various integer sizes, unsigned integers, binary data, date/time types, and decimal values.
- Adds support for Int8, Int16, Int32, UInt8, UInt16, UInt32, UInt64, and Float32 data types
- Implements binary data encoding using base64
- Adds comprehensive date, time, and timestamp handling with proper TimeUnit matching
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ext/trex/lib.rs | Adds extensive data type handling in field_value_to_json function with proper Arrow array imports |
| ext/trex/Cargo.toml | Adds base64 dependency for binary data encoding |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.