refactor(swift-sdk): key management#3050
Merged
Merged
Conversation
- Add new validator methods to AddressValidator: - validateBech32mAddress() for bech32m Platform addresses - validateAddress() with auto-detection (hex or bech32m) - validateHash() for 32-byte hashes - validateIdentityIdHex() and isHexIdentityId() for identity IDs - Create comprehensive unit tests for all validators (40+ tests) covering AddressValidator, TransferInputValidator, WithdrawInputValidator, TopUpAddressFromAssetLockValidator, and Identity validators - Update views to use centralized validators: - AddressQueriesView: use validateHash() - DocumentWithPriceView: use isHexIdentityId() - TransitionDetailView: use isHexIdentityId()
Add DataTransformers.swift with utilities for address, number, and response transformations: - AddressTransformer: hex/Data conversion, bech32m parsing, identity ID normalization - NumberTransformer: UInt64/UInt32 parsing, amount formatting, credits/duffs to Dash - ResponseParser: PlatformAddressInfo parsing and formatting - TransferInputBuilder: create transfer inputs/outputs from form strings Update ViewModels to use new transformers: - AddressTransferViewModel: use TransferInputBuilder - WithdrawAddressFundsViewModel: use TransferInputBuilder and NumberTransformer - TopUpAddressFromAssetLockViewModel: use AddressTransformer and NumberTransformer Add comprehensive unit tests for all transformer functionality (39 tests).
Add PrivateKeyUtils.swift with utilities for private key management: - KeyFormatDetector: detect hex vs WIF format - PrivateKeyParser: parse keys from hex or WIF with detailed error messages - KeyValidator: validate private keys against public keys - KeySizeValidator: validate key sizes for different key types - KeyFormatter: format keys for display (hex, WIF, truncated) Add comprehensive unit tests for all key utilities (29 tests). Update KeyDetailView to use centralized PrivateKeyParser and KeyValidator instead of inline parsing logic.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
✅ DashSDKFFI.xcframework built for this PR.
SwiftPM (host the zip at a stable URL, then use): .binaryTarget(
name: "DashSDKFFI",
url: "https://your.cdn.example/DashSDKFFI.xcframework.zip",
checksum: "b08c4ea2b28883b77e4a016680b8a15e464a99e9cb7d2159877276173bc1affa"
)Xcode manual integration:
|
QuantumExplorer
approved these changes
Feb 4, 2026
shumkov
added a commit
that referenced
this pull request
May 13, 2026
Extracts the resumable-asset-lock filter from CreateIdentityView into a pure static `resumableLocks(in:usedIndices:walletId:)` generic over a new `AssetLockResumeRow` protocol so unit tests can exercise the business logic without spinning up a SwiftData ModelContainer. View keeps its private `resumableAssetLocks(for:)` entry point as a one-line wrapper that supplies the live `@Query` results. Eight test cases cover the three pieces of logic that can silently regress: - walletId match (cross-wallet bleed) - statusRaw >= 2 floor (Built/Broadcast rejected, ISLock/CLock accepted, forward-compatible for any future status >= 2) - anti-join against the per-wallet used-slot set (including the Int32 -> UInt32 bitPattern bridge for the negative-index edge) Drive-by fix: KeyManagerTests:178 was calling `KeyFormatter.toWIF(_, isTestnet:)` but the SDK changed the signature to `network:` in #3050 (Feb 2026); the test target couldn't build. Updated the call so `xcodebuild test` works again. All 8 new tests pass on iPhone 17 Pro sim (iOS 26.4.1). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Phase 3 of Swift SDK refactoring: Centralize private key management utilities for better code reuse and consistent error handling.
What was done?
Added
PrivateKeyUtils.swiftwith centralized utilities for private key operations:Updated Views to use new centralized utilities:
KeyDetailView: UsesPrivateKeyParserandKeyValidatorinstead of inline parsing logicHow Has This Been Tested?
KeyManagerTests.swiftBreaking Changes
None
Checklist: