-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Closed
Labels
Description
What would you like?
Currently, the logic for timing out on uploading test replay data is set at 2 minutes. We also have retrying logic that attempts to retry 8 times on failures. This ends up being over 16 minutes of waiting if the upload URL will never be reachable. To resolve this, I propose:
- Reducing the upload time based on some maximum upload times we've seen in the wild
node-fetchmay not support all that we want to do here, but we can likely tap into our agent to listen to the appropriate events- We should mimic what @cypress/request does and provide timeouts in multiple scenarios (https://github.com/cypress-io/request/blob/master/request.js#L799-L851):
- socket connect (to upstream)
- response sent (headers/status code)
- data flowing
- response complete (possibly this one should be very high)
- Detect when a timeout has occurred more than once and fail immediately (other retries would work as they do today)
More context:
- https://cypressio.slack.com/archives/C02FKC77SR1/p1707414373773239
- https://cypressio.slack.com/archives/C045K9KUWR2/p1707342711145369
Why is this needed?
No response
Other
No response